Fixes in Tethys CLI for Creating THREDDS Services#1272
Open
jakeymac wants to merge 3 commits into
Open
Conversation
* Added new endpoint argument to spatial services creation
|
Coverage is 99.993% — spatial-dataset-cli-fix into main. No base build found for |
swainn
requested changes
May 22, 2026
| service_username = cred_parts[0] | ||
| service_password = cred_parts[1] | ||
| endpoint = parts[1] | ||
| if connection: |
Member
There was a problem hiding this comment.
Are endpoint and connection mutually exclusive? If so, we need to check and throw an error if neither are provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This merge request addresses an inconsistency in the CLI command for creating a spatial dataset service. This addresses issues in creating THREDDS services as they don't often require usernames and passwords that are a required part of the
connectionargument.Changes Made to Code
connectionargument no longer requiredendpointrequirement to be used instead of including the endpoint in aconnectionargument.Quality Checks