Skip to content

fix: update the default port to 443 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Aashiq-J wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: update the default port to 443 #64

Aashiq-J wants to merge 4 commits into from
+13 −11

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Nov 11, 2025 •
edited
Loading

Description

update the default port to 443

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Nov 11, 2025

/run pipeline

@ocofaigh
Copy link
Contributor

ocofaigh commented Nov 28, 2025

@Aashiq-J This still required?

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Dec 9, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Dec 9, 2025 

=== NAME  TestRunUpgradeFullyConfigurable
    terraform.go:243: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testhelper/terraform.go:243
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:273
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:50
        	            				/__w/terraform-ibm-vpc-private-path-external-connectivity/terraform-ibm-vpc-private-path-external-connectivity/tests/pr_test.go:145
        	Error:      	Should be false
        	Test:       	TestRunUpgradeFullyConfigurable
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: alb_pool_members
        	            	Address: ibm_is_lb_pool_member.alb_pool_members[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"port":80}
        	            	  After: 
        	            		{"port":443}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],
        	            	  "after": {
        	            	    "health": "faulted",
        	            	    "href": "https://ca-tor.private.iaas.cloud.ibm.com/v1/load_balancers/r038-c2a3c93b-1421-4d34-ba71-653e65027d96/pools/r038-5622ca1b-a95a-4d85-88fe-9d1d8f83cda9/members/r038-0c5562dd-60f6-4643-959c-285509494aa8",
        	            	    "id": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96/r038-5622ca1b-a95a-4d85-88fe-9d1d8f83cda9/r038-0c5562dd-60f6-4643-959c-285509494aa8",
        	            	    "lb": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "pool": "r038-5622ca1b-a95a-4d85-88fe-9d1d8f83cda9",
        	            	    "port": 443,
        	            	    "provisioning_status": "active",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "target_address": "163.66.93.96",
        	            	    "target_id": null,
        	            	    "timeouts": null,
        	            	    "weight": 50
        	            	  },
        	            	  "after_sensitive": {},
        	            	  "after_unknown": {},
        	            	  "before": {
        	            	    "health": "faulted",
        	            	    "href": "https://ca-tor.private.iaas.cloud.ibm.com/v1/load_balancers/r038-c2a3c93b-1421-4d34-ba71-653e65027d96/pools/r038-5622ca1b-a95a-4d85-88fe-9d1d8f83cda9/members/r038-0c5562dd-60f6-4643-959c-285509494aa8",
        	            	    "id": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96/r038-5622ca1b-a95a-4d85-88fe-9d1d8f83cda9/r038-0c5562dd-60f6-4643-959c-285509494aa8",
        	            	    "lb": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "pool": "r038-5622ca1b-a95a-4d85-88fe-9d1d8f83cda9",
        	            	    "port": 80,
        	            	    "provisioning_status": "active",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "target_address": "163.66.93.96",
        	            	    "target_id": null,
        	            	    "timeouts": null,
        	            	    "weight": 50
        	            	  },
        	            	  "before_sensitive": {}
        	            	}
    terraform.go:243: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testhelper/terraform.go:243
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:273
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:50
        	            				/__w/terraform-ibm-vpc-private-path-external-connectivity/terraform-ibm-vpc-private-path-external-connectivity/tests/pr_test.go:145
        	Error:      	Should be false
        	Test:       	TestRunUpgradeFullyConfigurable
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: listener
        	            	Address: module.private_path.ibm_is_lb_listener.listener["on-prem"]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"port_max":80,"port_min":80}
        	            	  After: 
        	            		{"port_max":443,"port_min":443}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],
        	            	  "after": {
        	            	    "accept_proxy_protocol": false,
        	            	    "certificate_instance": null,
        	            	    "connection_limit": null,
        	            	    "default_pool": "r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26",
        	            	    "https_redirect": "SECURE_VALUE_HIDDEN_HASH:-cd471a19f326c723e577871b2b1b6798eec45c4019882c941286c3bf",
        	            	    "https_redirect_listener": null,
        	            	    "https_redirect_status_code": null,
        	            	    "https_redirect_uri": null,
        	            	    "id": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8/r038-2e8cf457-3149-4e8d-9f97-f47e6cbf07d1",
        	            	    "idle_connection_timeout": null,
        	            	    "lb": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "listener_id": "r038-2e8cf457-3149-4e8d-9f97-f47e6cbf07d1",
        	            	    "port": 80,
        	            	    "port_max": 443,
        	            	    "port_min": 443,
        	            	    "protocol": "tcp",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "status": "active",
        	            	    "timeouts": null
        	            	  },
        	            	  "after_sensitive": {
        	            	    "https_redirect": []
        	            	  },
        	            	  "after_unknown": {},
        	            	  "before": {
        	            	    "accept_proxy_protocol": false,
        	            	    "certificate_instance": null,
        	            	    "connection_limit": null,
        	            	    "default_pool": "r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26",
        	            	    "https_redirect": "SECURE_VALUE_HIDDEN_HASH:-5610371e60607314b4566933952977ef3a851b5319957aba51073e3c",
        	            	    "https_redirect_listener": null,
        	            	    "https_redirect_status_code": null,
        	            	    "https_redirect_uri": null,
        	            	    "id": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8/r038-2e8cf457-3149-4e8d-9f97-f47e6cbf07d1",
        	            	    "idle_connection_timeout": null,
        	            	    "lb": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "listener_id": "r038-2e8cf457-3149-4e8d-9f97-f47e6cbf07d1",
        	            	    "port": 80,
        	            	    "port_max": 80,
        	            	    "port_min": 80,
        	            	    "protocol": "tcp",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "status": "active",
        	            	    "timeouts": null
        	            	  },
        	            	  "before_sensitive": {
        	            	    "https_redirect": []
        	            	  }
        	            	}
    terraform.go:243: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testhelper/terraform.go:243
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:273
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:50
        	            				/__w/terraform-ibm-vpc-private-path-external-connectivity/terraform-ibm-vpc-private-path-external-connectivity/tests/pr_test.go:145
        	Error:      	Should be false
        	Test:       	TestRunUpgradeFullyConfigurable
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: nlb_pool_members
        	            	Address: module.private_path.ibm_is_lb_pool_member.nlb_pool_members["on-prem"]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"port":80}
        	            	  After: 
        	            		{"port":443}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],
        	            	  "after": {
        	            	    "health": "ok",
        	            	    "href": "https://ca-tor.private.iaas.cloud.ibm.com/v1/load_balancers/r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8/pools/r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26/members/r038-5cc84a97-7ca5-4fe6-8c08-0bb1f46b89b5",
        	            	    "id": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8/r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26/r038-5cc84a97-7ca5-4fe6-8c08-0bb1f46b89b5",
        	            	    "lb": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "pool": "r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26",
        	            	    "port": 443,
        	            	    "provisioning_status": "active",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "target_address": null,
        	            	    "target_id": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "timeouts": null,
        	            	    "weight": null
        	            	  },
        	            	  "after_sensitive": {},
        	            	  "after_unknown": {},
        	            	  "before": {
        	            	    "health": "ok",
        	            	    "href": "https://ca-tor.private.iaas.cloud.ibm.com/v1/load_balancers/r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8/pools/r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26/members/r038-5cc84a97-7ca5-4fe6-8c08-0bb1f46b89b5",
        	            	    "id": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8/r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26/r038-5cc84a97-7ca5-4fe6-8c08-0bb1f46b89b5",
        	            	    "lb": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "pool": "r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26",
        	            	    "port": 80,
        	            	    "provisioning_status": "active",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "target_address": null,
        	            	    "target_id": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "timeouts": null,
        	            	    "weight": null
        	            	  },
        	            	  "before_sensitive": {}
        	            	}
    terraform.go:243: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testhelper/terraform.go:243
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:273
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:50
        	            				/__w/terraform-ibm-vpc-private-path-external-connectivity/terraform-ibm-vpc-private-path-external-connectivity/tests/pr_test.go:145
        	Error:      	Should be false
        	Test:       	TestRunUpgradeFullyConfigurable
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: alb_frontend_listener
        	            	Address: ibm_is_lb_listener.alb_frontend_listener
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"port":80}
        	            	  After: 
        	            		{"port":443}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],
        	            	  "after": {
        	            	    "accept_proxy_protocol": false,
        	            	    "certificate_instance": null,
        	            	    "connection_limit": null,
        	            	    "default_pool": "r038-5622ca1b-a95a-4d85-88fe-9d1d8f83cda9",
        	            	    "https_redirect": "SECURE_VALUE_HIDDEN_HASH:-f0be80b86789194ccb9422a57feea539fe119e1c569c7b139926ecad",
        	            	    "https_redirect_listener": null,
        	            	    "https_redirect_status_code": null,
        	            	    "https_redirect_uri": null,
        	            	    "id": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96/r038-c572cb41-a288-42c8-a51b-eeb92cefc87d",
        	            	    "idle_connection_timeout": 50,
        	            	    "lb": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "listener_id": "r038-c572cb41-a288-42c8-a51b-eeb92cefc87d",
        	            	    "port": 443,
        	            	    "port_max": 80,
        	            	    "port_min": 80,
        	            	    "protocol": "http",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "status": "active",
        	            	    "timeouts": null
        	            	  },
        	            	  "after_sensitive": {
        	            	    "https_redirect": []
        	            	  },
        	            	  "after_unknown": {},
        	            	  "before": {
        	            	    "accept_proxy_protocol": false,
        	            	    "certificate_instance": null,
        	            	    "connection_limit": null,
        	            	    "default_pool": "r038-5622ca1b-a95a-4d85-88fe-9d1d8f83cda9",
        	            	    "https_redirect": "SECURE_VALUE_HIDDEN_HASH:-e45b2f9a1de3d5510efffc0e5f15e99777106182e99825a170e93872",
        	            	    "https_redirect_listener": null,
        	            	    "https_redirect_status_code": null,
        	            	    "https_redirect_uri": null,
        	            	    "id": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96/r038-c572cb41-a288-42c8-a51b-eeb92cefc87d",
        	            	    "idle_connection_timeout": 50,
        	            	    "lb": "r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "listener_id": "r038-c572cb41-a288-42c8-a51b-eeb92cefc87d",
        	            	    "port": 80,
        	            	    "port_max": 80,
        	            	    "port_min": 80,
        	            	    "protocol": "http",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-c2a3c93b-1421-4d34-ba71-653e65027d96",
        	            	    "status": "active",
        	            	    "timeouts": null
        	            	  },
        	            	  "before_sensitive": {
        	            	    "https_redirect": []
        	            	  }
        	            	}
    terraform.go:243: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testhelper/terraform.go:243
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:273
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.60.34/testschematic/tests.go:50
        	            				/__w/terraform-ibm-vpc-private-path-external-connectivity/terraform-ibm-vpc-private-path-external-connectivity/tests/pr_test.go:145
        	Error:      	Should be false
        	Test:       	TestRunUpgradeFullyConfigurable
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: pool
        	            	Address: module.private_path.ibm_is_lb_pool.pool["on-prem"]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"health_monitor_port":80}
        	            	  After: 
        	            		{"health_monitor_port":443}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],
        	            	  "after": {
        	            	    "algorithm": "round_robin",
        	            	    "failsafe_policy": "SECURE_VALUE_HIDDEN_HASH:-9226066546ad44dd543f8c5eb5a14c9ac43aaecf9c99a8c2ddaad6aa",
        	            	    "health_delay": 5,
        	            	    "health_monitor_port": 443,
        	            	    "health_monitor_url": null,
        	            	    "health_retries": 2,
        	            	    "health_timeout": 2,
        	            	    "health_type": "tcp",
        	            	    "id": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8/r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26",
        	            	    "lb": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "name": "on-prem",
        	            	    "pool_id": "r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26",
        	            	    "protocol": "tcp",
        	            	    "provisioning_status": "active",
        	            	    "proxy_protocol": "disabled",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "session_persistence_app_cookie_name": "",
        	            	    "session_persistence_http_cookie_name": "",
        	            	    "session_persistence_type": "",
        	            	    "timeouts": null
        	            	  },
        	            	  "after_sensitive": {
        	            	    "failsafe_policy": [
        	            	      {
        	            	        "target": []
        	            	      }
        	            	    ]
        	            	  },
        	            	  "after_unknown": {},
        	            	  "before": {
        	            	    "algorithm": "round_robin",
        	            	    "failsafe_policy": "SECURE_VALUE_HIDDEN_HASH:-0eda979f7db786c8f18b43c7def49567257482ecfdcc576de710a2b0",
        	            	    "health_delay": 5,
        	            	    "health_monitor_port": 80,
        	            	    "health_monitor_url": null,
        	            	    "health_retries": 2,
        	            	    "health_timeout": 2,
        	            	    "health_type": "tcp",
        	            	    "id": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8/r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26",
        	            	    "lb": "r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "name": "on-prem",
        	            	    "pool_id": "r038-f81c6eaa-9e71-49ea-9670-f0cf445c3d26",
        	            	    "protocol": "tcp",
        	            	    "provisioning_status": "active",
        	            	    "proxy_protocol": "disabled",
        	            	    "related_crn": "crn:v1:bluemix:public:is:ca-tor:a/abac0df06b644a9cabc6e44f55b3880e::load-balancer:r038-d-7210317b-a93b-4c87-bf79-3da2a7d0d6a8",
        	            	    "session_persistence_app_cookie_name": "",
        	            	    "session_persistence_http_cookie_name": "",
        	            	    "session_persistence_type": "",
        	            	    "timeouts": null
        	            	  },
        	            	  "before_sensitive": {
        	            	    "failsafe_policy": [
        	            	      {
        	            	        "target": []
        	            	      }
        	            	    ]
        	            	  }
        	            	}

This is expected, skipping upgrade test.

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Dec 9, 2025

/run pipeline

@maheshwarishikha
Copy link
Member

maheshwarishikha commented Dec 9, 2025

@Aashiq-J This still required?

@ocofaigh yes, IRM has been created 2 weeks ago, so will use this PR as a mitigation of that IRM. I am working with Mukul to create remedial task against that IRM, will merge post that.

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Dec 9, 2025

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aayush-Abhyarthi Aayush-Abhyarthi Awaiting requested review from Aayush-Abhyarthi Aayush-Abhyarthi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aashiq-J @ocofaigh @maheshwarishikha