Build Electron with GTK+ 3

[tensor5]

This is done in the electron_gtk3 branch.

Atom and Electron's default app crash on keypress. No problem arises during the build of libchromiumcontent, but there are some warnings from Electron:

[...]
[946/1080] CXX obj/atom/browser/ui/electron_lib.file_dialog_gtk.o
../../atom/browser/ui/file_dialog_gtk.cc:45:32: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
    const char* confirm_text = GTK_STOCK_OK;
                               ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:756:38: note: expanded from macro 'GTK_STOCK_OK'
#define GTK_STOCK_OK               ((GtkStock)"gtk-ok")
                                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:108:16: note: 'GtkStock' has been explicitly marked deprecated here
typedef char * GtkStock;
               ^
../../atom/browser/ui/file_dialog_gtk.cc:50:22: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
      confirm_text = GTK_STOCK_SAVE;
                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:964:38: note: expanded from macro 'GTK_STOCK_SAVE'
#define GTK_STOCK_SAVE             ((GtkStock)"gtk-save")
                                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:108:16: note: 'GtkStock' has been explicitly marked deprecated here
typedef char * GtkStock;
               ^
../../atom/browser/ui/file_dialog_gtk.cc:52:22: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
      confirm_text = GTK_STOCK_OPEN;
                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:765:38: note: expanded from macro 'GTK_STOCK_OPEN'
#define GTK_STOCK_OPEN             ((GtkStock)"gtk-open")
                                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:108:16: note: 'GtkStock' has been explicitly marked deprecated here
typedef char * GtkStock;
               ^
../../atom/browser/ui/file_dialog_gtk.cc:58:9: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
        GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
        ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:159:38: note: expanded from macro 'GTK_STOCK_CANCEL'
#define GTK_STOCK_CANCEL           ((GtkStock)"gtk-cancel")
                                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:108:16: note: 'GtkStock' has been explicitly marked deprecated here
typedef char * GtkStock;
               ^
4 warnings generated.
[947/1080] CXX obj/atom/browser/ui/electron_lib.tray_icon.o
[948/1080] CXX obj/atom/browser/ui/electron_lib.message_box_gtk.o
../../atom/browser/ui/message_box_gtk.cc:56:35: warning: 'gtk_icon_source_new' is deprecated [-Wdeprecated-declarations]
      GtkIconSource* iconsource = gtk_icon_source_new();
                                  ^
/usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:170:16: note: 'gtk_icon_source_new' has been explicitly marked deprecated here
GtkIconSource* gtk_icon_source_new                      (void);
               ^
../../atom/browser/ui/message_box_gtk.cc:57:29: warning: 'gtk_icon_set_new' is deprecated [-Wdeprecated-declarations]
      GtkIconSet* iconset = gtk_icon_set_new();
                            ^
/usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:138:13: note: 'gtk_icon_set_new' has been explicitly marked deprecated here
GtkIconSet* gtk_icon_set_new             (void);
            ^
../../atom/browser/ui/message_box_gtk.cc:58:7: warning: 'gtk_icon_source_set_pixbuf' is deprecated [-Wdeprecated-declarations]
      gtk_icon_source_set_pixbuf(iconsource, pixbuf);
      ^
/usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:183:16: note: 'gtk_icon_source_set_pixbuf' has been explicitly marked deprecated here
void           gtk_icon_source_set_pixbuf               (GtkIconSource       *source,
               ^
../../atom/browser/ui/message_box_gtk.cc:59:7: warning: 'gtk_icon_set_add_source' is deprecated [-Wdeprecated-declarations]
      gtk_icon_set_add_source(iconset, iconsource);
      ^
/usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:159:16: note: 'gtk_icon_set_add_source' has been explicitly marked deprecated here
void           gtk_icon_set_add_source   (GtkIconSet          *icon_set,
               ^
../../atom/browser/ui/message_box_gtk.cc:60:26: warning: 'gtk_image_new_from_icon_set' is deprecated [-Wdeprecated-declarations]
      GtkWidget* image = gtk_image_new_from_icon_set(iconset,
                         ^
/usr/include/gtk-3.0/gtk/gtkimage.h:125:12: note: 'gtk_image_new_from_icon_set' has been explicitly marked deprecated here
GtkWidget* gtk_image_new_from_icon_set  (GtkIconSet      *icon_set,
           ^
../../atom/browser/ui/message_box_gtk.cc:62:7: warning: 'gtk_message_dialog_set_image' is deprecated [-Wdeprecated-declarations]
      gtk_message_dialog_set_image(GTK_MESSAGE_DIALOG(dialog_), image);
      ^
/usr/include/gtk-3.0/gtk/gtkmessagedialog.h:115:12: note: 'gtk_message_dialog_set_image' has been explicitly marked deprecated here
void       gtk_message_dialog_set_image    (GtkMessageDialog *dialog,
           ^
../../atom/browser/ui/message_box_gtk.cc:64:7: warning: 'gtk_icon_source_free' is deprecated [-Wdeprecated-declarations]
      gtk_icon_source_free(iconsource);
      ^
/usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:174:16: note: 'gtk_icon_source_free' has been explicitly marked deprecated here
void           gtk_icon_source_free                     (GtkIconSource       *source);
               ^
../../atom/browser/ui/message_box_gtk.cc:65:7: warning: 'gtk_icon_set_unref' is deprecated [-Wdeprecated-declarations]
      gtk_icon_set_unref(iconset);
      ^
/usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:145:13: note: 'gtk_icon_set_unref' has been explicitly marked deprecated here
void        gtk_icon_set_unref           (GtkIconSet      *icon_set);
            ^
../../atom/browser/ui/message_box_gtk.cc:106:14: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
      return GTK_STOCK_CANCEL;
             ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:159:38: note: expanded from macro 'GTK_STOCK_CANCEL'
#define GTK_STOCK_CANCEL           ((GtkStock)"gtk-cancel")
                                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:108:16: note: 'GtkStock' has been explicitly marked deprecated here
typedef char * GtkStock;
               ^
../../atom/browser/ui/message_box_gtk.cc:108:14: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
      return GTK_STOCK_NO;
             ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:747:38: note: expanded from macro 'GTK_STOCK_NO'
#define GTK_STOCK_NO               ((GtkStock)"gtk-no")
                                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:108:16: note: 'GtkStock' has been explicitly marked deprecated here
typedef char * GtkStock;
               ^
../../atom/browser/ui/message_box_gtk.cc:110:14: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
      return GTK_STOCK_OK;
             ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:756:38: note: expanded from macro 'GTK_STOCK_OK'
#define GTK_STOCK_OK               ((GtkStock)"gtk-ok")
                                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:108:16: note: 'GtkStock' has been explicitly marked deprecated here
typedef char * GtkStock;
               ^
../../atom/browser/ui/message_box_gtk.cc:112:14: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
      return GTK_STOCK_YES;
             ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:1094:38: note: expanded from macro 'GTK_STOCK_YES'
#define GTK_STOCK_YES              ((GtkStock)"gtk-yes")
                                     ^
/usr/include/gtk-3.0/gtk/deprecated/gtkstock.h:108:16: note: 'GtkStock' has been explicitly marked deprecated here
typedef char * GtkStock;
               ^
12 warnings generated.
[949/1080] CXX obj/atom/browser/ui/views/electron_lib.frameless_view.o
[950/1080] CXX obj/atom/browser/ui/views/electron_lib.global_menu_bar_x11.o
[951/1080] CXX obj/atom/browser/ui/views/electron_lib.menu_layout.o
[952/1080] CXX obj/atom/browser/ui/views/electron_lib.menu_delegate.o
[953/1080] CXX obj/atom/browser/ui/views/electron_lib.native_frame_view.o
[954/1080] CXX obj/atom/browser/ui/views/electron_lib.menu_bar.o
../../atom/browser/ui/views/menu_bar.cc:37:21: warning: 'gtk_rc_get_style' is deprecated [-Wdeprecated-declarations]
  GtkStyle* style = gtk_rc_get_style(menu_bar);
                    ^
/usr/include/gtk-3.0/gtk/deprecated/gtkrc.h:175:11: note: 'gtk_rc_get_style' has been explicitly marked deprecated here
GtkStyle* gtk_rc_get_style              (GtkWidget   *widget);
          ^
1 warning generated.
[...]

Upstream issue here.

[tensor5]

Thanks to the brilliant solution of @nikolowry, as of v1.2.4 our build of Electron uses GTK+ 3.

I'll leave this issue open until we are sure that the build with the new option is completely stable.

[tensor5]

Text in the menu bar is white.

[repsac-by]

On hidpi display font is too small. Do not scaled as it should. Before gtk3 all was well.

[tensor5]

@repsac-by Can you attach a screenshot?

[repsac-by]

[tensor5]

Can you manually increase the font size in Atom, or does it look weird?

I don't have a hidpi display, but I noticed that gnome-tweak-tool has a setting Fonts -> Scaling Factor. Have you tried that one?

[tensor5]

I also found this https://wiki.archlinux.org/index.php/HiDPI#GDK_3_.28GTK.2B_3.29
Please try and let me know.

[repsac-by]

Setting the font size in the atom only affects the source code editor.

Yes it is in the gnome-tweak-tool has HiDPI factor 2. Before gtk3 electron scaled, but now no longer. Other applications on the electron look the same, not only Atom.

[tensor5]

I'll revert to gtk2 in the next build.

[repsac-by]

GDK_SCALE=2 it changes the scale

[tensor5]

Strange, I tried on mine and didn't do anything.

[repsac-by]

Even if you set GDK_SCALE=1 the scale remains correct. It turns out it is important the very existence of environment variable.

[tensor5]

If your problem is completely solved, we will stay with gtk3 for now and see if other issues come up.

[repsac-by]

Well, not completely, but I am willing to suffer for a while. 👍