Enable Worker heartbeating, plumb plugin names to core, update Core to 45b1d7e #1818
Conversation
yuandrew
force-pushed
the
worker-heartbeat
branch
from
1557d50 to
de87933
Compare
yuandrew
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Only required change is fixing up tests. Rest are light suggestions or questions.
packages/core-bridge/src/worker.rs
Outdated
| } | ||
| } | ||
| CompleteWfError::WorkflowNotEnabled => { | ||
| BridgeError::UnexpectedError(format!("{err}")) |
There was a problem hiding this comment.
No strong opinions on this 🤷
| BridgeError::UnexpectedError(format!("{err}")) | |
| BridgeError::UnexpectedError(err.to_string()) |
| .into_iter() | ||
| .map(|name| PluginInfo { | ||
| name, | ||
| version: String::new(), |
There was a problem hiding this comment.
Just for my own knowledge, is version from the past or not yet implemented?
There was a problem hiding this comment.
Good question, I don't know. haha. The API was originally implemented with version, but not sure what the intent was. Will follow up on this.
| taskTypes: { | ||
| enableWorkflows, | ||
| enableLocalActivities, | ||
| enableRemoteActivities: opts.enableNonLocalActivities && opts.activities.size > 0, |
There was a problem hiding this comment.
That's basically saying:
enableRemoteActivities: (enableWorkflows && opts.activities.size > 0) && opts.activities.size > 0
Which is incorrect. We don't need workflows to enable remote activities. I'm surprised tests passed with this.
There was a problem hiding this comment.
I don't think that's right, you're referring to enableLocalActivities, but I'm using opts.enableNonLocalActivities here
| max_activities_per_second: Option<f64>, | ||
| max_task_queue_activities_per_second: Option<f64>, | ||
| shutdown_grace_time: Option<Duration>, | ||
| plugins: Vec<String>, |
There was a problem hiding this comment.
I think we should consider deduping plugins if we don't already. Depending on plugin implementation, it may be very normal to configure multiple of the same plugin on the same worker (maybe each has different settings).
This should be done in every SDK IMO too if we don't already (could consider making that Vec a Set on the Core side).
There was a problem hiding this comment.
good point, a set would ensure deduping. Created temporalio/sdk-core#1072
4 participants
What was changed
WorkerTaskTypesbased on if workflows/activities/nexus handlers are registered to the workersdk-coreto45b1d7eWhy?
New feature!
Checklist
Closes [Feature Request] Enable Worker Heartbeating #1810
How was this tested:
Manually tested that heartbeats with a simple plugin from the worker and client both show up in plugins section of the worker heartbeat.
Also tested setting
workerHeartbeatInterval: nulldisables heartbeating for the workerNote
Adds runtime worker heartbeat interval, plumbs plugin names and derived WorkerTaskTypes to Core, updates error mapping, and adjusts tests/typings.
worker_heartbeat_interval_millisinRuntimeOptionsand sets Coreheartbeat_interval.RuntimeOptionsgainsworkerHeartbeatInterval; compiled toworkerHeartbeatIntervalMillisand sent vianative.newRuntime.telemetryOptionstoruntimeOptions.enableNonLocalActivitiesflag withtask_types/taskTypesand derive values based on registered workflows/activities/nexus.pluginsfrom TS to Core asPluginInfoset.WorkflowNotEnabledandActivityNotEnabledtoUnexpectedError; minor string formatting tweak for Nexus.native.tssignatures and shapes (newRuntime,RuntimeOptions,WorkerOptions.taskTypes,plugins).workerHeartbeatIntervalMillisandtaskTypes.Written by Cursor Bugbot for commit 11b0fa0. This will update automatically on new commits. Configure here.