Skip to content

Commit ea6afef

Browse files
authored
Update Dockerfile to use Go 1.25 and Add git workflow requirements to CLAUDE.md (#191)
Document that changes must go through PR process: - Never push directly to main branch - Always create a new branch for changes - Always submit a proper Pull Request for review Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Reapply "Update Dockerfile to use Go 1.25" This reverts commit 40ac369. Revert "Update tools to go 1.25 (#189)" This reverts commit 41d5e9a.
1 parent 40ac369 commit ea6afef

5 files changed

Lines changed: 12 additions & 7 deletions

File tree

.github/workflows/docker.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ jobs:
3939

4040
- uses: actions/setup-go@v6
4141
with:
42-
go-version: '1.25'
4342
go-version-file: 'go.mod'
4443
check-latest: true
4544

.github/workflows/pull-request.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,8 @@ jobs:
3232
#
3333
# See https://github.com/actions/setup-go/issues/316 for more info.
3434
- name: Install go
35-
uses: actions/setup-go@v6
35+
uses: actions/setup-go@v4
3636
with:
37-
go-version: '1.25'
3837
go-version-file: 'go.mod'
3938
cache: ${{ github.ref == 'refs/heads/main' }} # only update the cache in main.
4039

@@ -54,9 +53,8 @@ jobs:
5453
fetch-depth: 0
5554

5655
- name: Install go
57-
uses: actions/setup-go@v6
56+
uses: actions/setup-go@v4
5857
with:
59-
go-version: '1.25'
6058
go-version-file: 'go.mod'
6159
cache: ${{ github.ref == 'refs/heads/main' }} # only update the cache in main.
6260

CLAUDE.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Claude Code Guidelines for s2s-proxy
22

3+
## Git Workflow
4+
5+
### Branch and PR Requirements
6+
- **NEVER** push changes directly to `main` branch
7+
- **ALWAYS** create a new branch for changes
8+
- **ALWAYS** submit a proper Pull Request for code review
9+
- Branch naming convention: Use descriptive names like `username/feature-name`
10+
311
## Code Style & Conventions
412

513
### License Headers

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build stage
2-
FROM --platform=$BUILDPLATFORM temporalio/base-builder:1.15.5 AS builder
2+
FROM --platform=$BUILDPLATFORM golang:1.25-alpine AS builder
33

44
ARG TARGETARCH
55

develop/tools.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module tools
22

3-
go 1.25.0
3+
go 1.24.4
44

55
tool (
66
github.com/golangci/golangci-lint/v2/cmd/golangci-lint

0 commit comments

Comments
 (0)