Update config dir

Author: arjunkomath

README.md

@@ -87,7 +87,7 @@ push notify-group my-team --title "Standup" --body "Daily standup in 5 minutes"
 
 ## Configuration
 
-The API key is stored in `~/.push/config.yaml`.
+The API key is stored in `<config-dir>/push/config.yaml`, where `<config-dir>` is `~/Library/Application Support` on macOS, `~/.config` on Linux, and `%AppData%` on Windows.
 
 ## License
 

internal/config/config.go

@@ -12,19 +12,19 @@ import (
 var osExit = os.Exit
 
 const (
-	configDir  = ".push"
+	configDir  = "push"
 	configFile = "config"
 	configType = "yaml"
 )
 
 func Init() {
-	home, err := os.UserHomeDir()
+	cfgBase, err := os.UserConfigDir()
 	if err != nil {
-		fmt.Fprintf(os.Stderr, "Error finding home directory: %v\n", err)
+		fmt.Fprintf(os.Stderr, "Error finding config directory: %v\n", err)
 		osExit(1)
 	}
 
-	dir := filepath.Join(home, configDir)
+	dir := filepath.Join(cfgBase, configDir)
 	viper.AddConfigPath(dir)
 	viper.SetConfigName(configFile)
 	viper.SetConfigType(configType)
@@ -38,12 +38,12 @@ func Init() {
 }
 
 func SetAPIKey(key string) error {
-	home, err := os.UserHomeDir()
+	cfgBase, err := os.UserConfigDir()
 	if err != nil {
-		return fmt.Errorf("finding home directory: %w", err)
+		return fmt.Errorf("finding config directory: %w", err)
 	}
 
-	dir := filepath.Join(home, configDir)
+	dir := filepath.Join(cfgBase, configDir)
 	if err := os.MkdirAll(dir, 0700); err != nil {
 		return fmt.Errorf("creating config directory: %w", err)
 	}

internal/config/config_test.go

@@ -52,13 +52,15 @@ func TestMaskedAPIKey_NineChars(t *testing.T) {
 
 func TestInit_MalformedConfig(t *testing.T) {
 	tmpDir := t.TempDir()
-	configDir := filepath.Join(tmpDir, ".push")
-	os.MkdirAll(configDir, 0700)
-	os.WriteFile(filepath.Join(configDir, "config.yaml"), []byte(":::invalid yaml"), 0600)
+	t.Setenv("HOME", tmpDir)
 
-	origHome := os.Getenv("HOME")
-	os.Setenv("HOME", tmpDir)
-	defer os.Setenv("HOME", origHome)
+	cfgBase, err := os.UserConfigDir()
+	if err != nil {
+		t.Fatalf("UserConfigDir() error: %v", err)
+	}
+	cfgDir := filepath.Join(cfgBase, "push")
+	os.MkdirAll(cfgDir, 0700)
+	os.WriteFile(filepath.Join(cfgDir, "config.yaml"), []byte(":::invalid yaml"), 0600)
 
 	viper.Reset()
 
@@ -78,18 +80,19 @@ func TestInit_MalformedConfig(t *testing.T) {
 
 func TestSetAPIKey_FilePermissions(t *testing.T) {
 	tmpDir := t.TempDir()
-
-	origHome := os.Getenv("HOME")
-	os.Setenv("HOME", tmpDir)
-	defer os.Setenv("HOME", origHome)
+	t.Setenv("HOME", tmpDir)
 
 	viper.Reset()
 
 	if err := SetAPIKey("test-key"); err != nil {
 		t.Fatalf("SetAPIKey() error: %v", err)
 	}
 
-	configPath := filepath.Join(tmpDir, ".push", "config.yaml")
+	cfgBase, err := os.UserConfigDir()
+	if err != nil {
+		t.Fatalf("UserConfigDir() error: %v", err)
+	}
+	configPath := filepath.Join(cfgBase, "push", "config.yaml")
 	info, err := os.Stat(configPath)
 	if err != nil {
 		t.Fatalf("Stat(%q) error: %v", configPath, err)