Skip to content

Commit 99f5009

Browse files
committed
fix navigation dropdown
1 parent cf99fc3 commit 99f5009

File tree

3 files changed

+32
-39
lines changed

3 files changed

+32
-39
lines changed

app/models/user.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ def admin?
1717
def token_validation_response
1818
self.as_json(except: [
1919
:tokens, :created_at, :updated_at
20-
]).merge("role" => self.roles.map(&:name).join)
20+
]).merge("role" => self.roles.first.name)
2121
end
2222
end

app/resources/user_resource.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ class UserResource < JSONAPI::Resource
99
model_filters :email_contains
1010

1111
def role
12-
self._model.roles.map(&:name).join
12+
self._model.roles.first.name
1313
end
1414
end

client/src/components/App.js

Lines changed: 30 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@ import React, { Component } from 'react';
22
import { Link } from 'react-router';
33
import { connect } from 'react-redux';
44
import { isEmpty } from 'lodash';
5-
import { Collapse, Container, Navbar, NavbarToggler, Nav, NavItem, NavLink, Dropdown, DropdownToggle, DropdownMenu, DropdownItem } from 'reactstrap';
5+
import { Collapse, Container, Navbar, NavbarToggler, Nav, NavItem, NavLink, NavDropdown, DropdownToggle, DropdownMenu, DropdownItem } from 'reactstrap';
66

77
import { getUser, logout } from '../store/auth';
88

99
export class App extends Component {
1010
state = {
1111
isOpen: false,
12-
dropdownOpen: false,
1312
};
1413

1514
logout = (e) => {
@@ -18,7 +17,6 @@ export class App extends Component {
1817
};
1918

2019
toggle = () => this.setState({
21-
dropdownOpen: !this.state.dropdownOpen,
2220
isOpen: !this.state.isOpen
2321
});
2422

@@ -30,40 +28,35 @@ export class App extends Component {
3028
<div>
3129
<Navbar color="faded" light toggleable>
3230
<Container>
33-
<NavbarToggler right onClick={this.toggle} />
34-
<Collapse isOpen={this.state.isOpen} navbar>
35-
<Nav navbar>
36-
<NavItem>
37-
<NavLink href="/#/">Dashboard</NavLink>
38-
</NavItem>
39-
<NavItem>
40-
<NavLink href="/#/posts">Posts</NavLink>
41-
</NavItem>
42-
<NavItem>
43-
<NavLink href="/#/categories">Categories</NavLink>
44-
</NavItem>
45-
<NavItem>
46-
{
47-
userIsAdmin && <NavLink href="/#/users">Users</NavLink>
48-
}
49-
</NavItem>
50-
</Nav>
51-
<Nav navbar className="ml-auto">
52-
<NavItem>
53-
<Dropdown isOpen={this.state.dropdownOpen} toggle={this.toggle}>
54-
<DropdownToggle caret>
55-
{user.email}
56-
</DropdownToggle>
57-
<DropdownMenu right>
58-
<DropdownItem>
59-
<Link to="/profile">Profile</Link>
60-
</DropdownItem>
61-
<DropdownItem href onClick={this.logout}> Logout </DropdownItem>
62-
</DropdownMenu>
63-
</Dropdown>
64-
</NavItem>
65-
</Nav>
66-
</Collapse>
31+
<Nav navbar>
32+
<NavItem>
33+
<NavLink href="/#/">Dashboard</NavLink>
34+
</NavItem>
35+
<NavItem>
36+
<NavLink href="/#/posts">Posts</NavLink>
37+
</NavItem>
38+
<NavItem>
39+
<NavLink href="/#/categories">Categories</NavLink>
40+
</NavItem>
41+
<NavItem>
42+
{
43+
userIsAdmin && <NavLink href="/#/users">Users</NavLink>
44+
}
45+
</NavItem>
46+
</Nav>
47+
<Nav navbar className="ml-auto">
48+
<NavDropdown isOpen={this.state.isOpen} toggle={this.toggle}>
49+
<DropdownToggle caret>
50+
{user.email}
51+
</DropdownToggle>
52+
<DropdownMenu right>
53+
<DropdownItem>
54+
<Link to="/profile">Profile</Link>
55+
</DropdownItem>
56+
<DropdownItem href onClick={this.logout}> Logout </DropdownItem>
57+
</DropdownMenu>
58+
</NavDropdown>
59+
</Nav>
6760
</Container>
6861
</Navbar>
6962
<Container className="container-main">

0 commit comments

Comments
 (0)