chore: Fix Clang-GCC toolchain libstdc++ linking

refactor: Unify matrix-driven Go setup across CI workflows

ci: Unify init script handling across platforms

chore: Enforce C++17 and simplify build setup

chore: Downgrade Protoc and add CMake policy in CI workflows

chore: Downgrade setup-protoc & simplify init scripts

chore: Update Protoc version format to include 'v' prefix

chore: Align protobuf paths and downgrade setup-protoc

chore: Unify protobuf setup across OSes in CI

Author: Kybxd

.github/workflows/testing-cpp.yml

@@ -18,25 +18,30 @@ jobs:
       matrix:
         include:
           - os: ubuntu-latest
+            go-version: 1.21.x
+            init_script: bash init.sh
             gen_script: bash gen.sh
-            cmake_config: cmake -S . -B build -G "Ninja" -DCMAKE_BUILD_TYPE=Debug
             run_loader: ./bin/loader
           - os: windows-latest
+            go-version: 1.21.x
+            init_script: cmd /c init.bat
             gen_script: cmd /c gen.bat
-            cmake_config: cmake -S . -B build -G "Ninja" -DCMAKE_BUILD_TYPE=Debug
             run_loader: .\bin\loader.exe
 
+    name: test (${{ matrix.os }})
     runs-on: ${{ matrix.os }}
     timeout-minutes: 10
 
     steps:
       - name: Checkout Code
         uses: actions/checkout@v6
+        with:
+          submodules: recursive
 
       - name: Install Go
         uses: actions/setup-go@v6
         with:
-          go-version: 1.21.x
+          go-version: ${{ matrix.go-version }}
           cache: true
 
       - name: Install dependencies (Ubuntu)
@@ -52,16 +57,15 @@ jobs:
         uses: ilammy/msvc-dev-cmd@v1
 
       - name: Init submodules and build protobuf
-        shell: bash
-        run: bash init.sh
+        run: ${{ matrix.init_script }}
 
       - name: Generate protoconf
         working-directory: test/cpp-tableau-loader
         run: ${{ matrix.gen_script }}
 
       - name: CMake Configure
         working-directory: test/cpp-tableau-loader
-        run: ${{ matrix.cmake_config }}
+        run: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_STANDARD=17
 
       - name: CMake Build
         working-directory: test/cpp-tableau-loader

.github/workflows/testing-csharp.yml

@@ -18,43 +18,38 @@ jobs:
       matrix:
         include:
           - os: ubuntu-latest
+            go-version: 1.21.x
             gen_script: bash gen.sh
           - os: windows-latest
+            go-version: 1.21.x
             gen_script: cmd /c gen.bat
 
+    name: test (${{ matrix.os }})
     runs-on: ${{ matrix.os }}
     timeout-minutes: 10
 
     steps:
       - name: Checkout Code
         uses: actions/checkout@v6
+        with:
+          submodules: recursive
 
       - name: Install Go
         uses: actions/setup-go@v6
         with:
-          go-version: 1.21.x
+          go-version: ${{ matrix.go-version }}
           cache: true
 
       - name: Install .NET SDK
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: "8.0.x"
 
-      - name: Install dependencies (Ubuntu)
-        if: runner.os == 'Linux'
-        run: sudo apt-get update && sudo apt-get install -y cmake ninja-build
-
-      - name: Install dependencies (Windows)
-        if: runner.os == 'Windows'
-        run: choco install cmake ninja -y
-
-      - name: Setup MSVC (Windows)
-        if: runner.os == 'Windows'
-        uses: ilammy/msvc-dev-cmd@v1
-
-      - name: Init submodules and build protobuf
-        shell: bash
-        run: bash init.sh
+      - name: Install Protoc
+        uses: arduino/setup-protoc@v1
+        with:
+          version: "3.19.3"
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Generate protoconf
         working-directory: test/csharp-tableau-loader

.github/workflows/testing-go.yml

@@ -16,10 +16,17 @@ jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.21.x]
-        os: [ubuntu-latest, windows-latest]
+        include:
+          - os: ubuntu-latest
+            go-version: 1.21.x
+            gen_script: bash gen.sh
+          - os: windows-latest
+            go-version: 1.21.x
+            gen_script: cmd /c gen.bat
 
+    name: test (${{ matrix.os }})
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 10
 
     steps:
       - name: Checkout Code
@@ -34,17 +41,17 @@ jobs:
           cache: true
 
       - name: Install Protoc
-        uses: arduino/setup-protoc@v3
+        uses: arduino/setup-protoc@v1
         with:
-          version: "23.x"
+          version: "3.19.3"
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Install protoc-gen-go
         run: go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.34.2
 
       - name: Generate protoconf
-        shell: bash
-        run: PROTOC=protoc bash test/go-tableau-loader/gen.sh
+        working-directory: test/go-tableau-loader
+        run: ${{ matrix.gen_script }}
 
       - name: Vet
         run: go vet ./...

init.bat

@@ -13,21 +13,22 @@ cd /d "%repoRoot%"
 
 git submodule update --init --recursive
 
-REM google protobuf
-cd third_party\_submodules\protobuf
-git checkout v3.19.3
-git submodule update --init --recursive
-
 REM Build and install the C++ Protocol Buffer runtime and the Protocol Buffer compiler (protoc)
 REM Refer: https://github.com/protocolbuffers/protobuf/blob/3.19.x/cmake/README.md#cmake-configuration
-cd cmake
+cd third_party\_submodules\protobuf\cmake
 REM use Debug version
 REM - protobuf_MSVC_STATIC_RUNTIME defaults to ON, which uses static CRT (/MTd for Debug).
 REM   Our project's CMakeLists.txt also sets static CRT to match.
 REM - protobuf_WITH_ZLIB=OFF: disable ZLIB dependency to avoid ZLIB::ZLIB link requirement
 REM   in protobuf's exported CMake targets, which simplifies cross-platform builds.
 REM - protobuf_BUILD_SHARED_LIBS=OFF: build static libraries explicitly.
-cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -Dprotobuf_BUILD_TESTS=OFF -Dprotobuf_WITH_ZLIB=OFF -Dprotobuf_BUILD_SHARED_LIBS=OFF
+cmake -S . -B build -G Ninja ^
+  -DCMAKE_BUILD_TYPE=Debug ^
+  -DCMAKE_CXX_STANDARD=17 ^
+  -DCMAKE_POLICY_VERSION_MINIMUM=3.5 ^
+  -Dprotobuf_BUILD_TESTS=OFF ^
+  -Dprotobuf_WITH_ZLIB=OFF ^
+  -Dprotobuf_BUILD_SHARED_LIBS=OFF
 
 REM Compile the code
 cmake --build build --parallel

init.sh

@@ -11,23 +11,21 @@ git submodule update --init --recursive
 # On Ubuntu/Debian, you can install them with:
 # sudo apt-get install autoconf automake libtool curl make g++ unzip
 
-### reference: https://github.com/protocolbuffers/protobuf/tree/v3.19.3/src
-
-# google protobuf
-cd third_party/_submodules/protobuf
-git checkout v3.19.3
-git submodule update --init --recursive
-
 # Build and install the C++ Protocol Buffer runtime and the Protocol Buffer compiler (protoc)
 # Refer: https://github.com/protocolbuffers/protobuf/blob/3.19.x/cmake/README.md#cmake-configuration
-cd cmake
+cd third_party/_submodules/protobuf/cmake
 # use Debug version
 # - protobuf_MSVC_STATIC_RUNTIME defaults to ON, which uses static CRT (/MTd for Debug).
 #   Our project's CMakeLists.txt also sets static CRT to match.
 # - protobuf_WITH_ZLIB=OFF: disable ZLIB dependency to avoid ZLIB::ZLIB link requirement
 #   in protobuf's exported CMake targets, which simplifies cross-platform builds.
 # - protobuf_BUILD_SHARED_LIBS=OFF: build static libraries explicitly.
-cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -Dprotobuf_BUILD_TESTS=OFF -Dprotobuf_WITH_ZLIB=OFF -Dprotobuf_BUILD_SHARED_LIBS=OFF
+cmake -S . -B build -G Ninja \
+    -DCMAKE_BUILD_TYPE=Debug \
+    -DCMAKE_CXX_STANDARD=17 \
+    -Dprotobuf_BUILD_TESTS=OFF \
+    -Dprotobuf_WITH_ZLIB=OFF \
+    -Dprotobuf_BUILD_SHARED_LIBS=OFF
 
 # Compile the code
 cmake --build build --parallel

test/cpp-tableau-loader/CMakeLists.txt

@@ -59,5 +59,24 @@ set(EXECUTABLE_OUTPUT_PATH ${PROJECT_SOURCE_DIR}/bin)
 # link libraries
 target_link_libraries(${PROJECT_NAME} protobuf::libprotobuf)
 if(NOT MSVC)
+    # When using clang with a GCC toolchain (e.g. gcc-toolset-13 on RHEL/CentOS),
+    # clang selects GCC 13's C++ headers but the C compiler (GCC 8) may inject an
+    # older libstdc++ search path into the link line. This causes undefined references
+    # to symbols like std::__throw_bad_array_new_length() and std::filesystem::*.
+    # Detect the GCC library directory used by the CXX compiler and link stdc++/stdc++fs
+    # from there explicitly.
+    if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+        execute_process(
+            COMMAND ${CMAKE_CXX_COMPILER} -print-libgcc-file-name
+            OUTPUT_VARIABLE _LIBGCC_FILE
+            OUTPUT_STRIP_TRAILING_WHITESPACE
+        )
+        if(_LIBGCC_FILE)
+            get_filename_component(_GCC_LIB_DIR "${_LIBGCC_FILE}" DIRECTORY)
+            message(STATUS "Detected GCC library directory for clang: ${_GCC_LIB_DIR}")
+            # Prepend GCC toolchain lib dir so it is searched before the system GCC 8 path.
+            target_link_options(${PROJECT_NAME} PRIVATE "-L${_GCC_LIB_DIR}")
+        endif()
+    endif()
     target_link_libraries(${PROJECT_NAME} pthread stdc++fs)
 endif()