Skip to content

Commit b5872a0

Browse files
committed
fix: assert on warning instead of ignore
1 parent 3b76175 commit b5872a0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/test_user.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,23 +259,23 @@ def test_populate_groups(self) -> None:
259259
self.assertEqual("TableauExample", group_list[2].name)
260260
self.assertEqual("local", group_list[2].domain_name)
261261

262-
@pytest.mark.filterwarnings("ignore:This method is deprecated, use bulk_add instead")
263262
def test_get_usernames_from_file(self):
264263
with open(ADD_XML, "rb") as f:
265264
response_xml = f.read().decode("utf-8")
266265
with requests_mock.mock() as m:
267266
m.post(self.server.users.baseurl, text=response_xml)
268-
user_list, failures = self.server.users.create_from_file(USERNAMES)
267+
with pytest.warns(DeprecationWarning, match="This method is deprecated, use bulk_add instead"):
268+
user_list, failures = self.server.users.create_from_file(USERNAMES)
269269
assert user_list[0].name == "Cassie", user_list
270270
assert failures == [], failures
271271

272-
@pytest.mark.filterwarnings("ignore:This method is deprecated, use bulk_add instead")
273272
def test_get_users_from_file(self):
274273
with open(ADD_XML, "rb") as f:
275274
response_xml = f.read().decode("utf-8")
276275
with requests_mock.mock() as m:
277276
m.post(self.server.users.baseurl, text=response_xml)
278-
users, failures = self.server.users.create_from_file(USERS)
277+
with pytest.warns(DeprecationWarning, match="This method is deprecated, use bulk_add instead"):
278+
users, failures = self.server.users.create_from_file(USERS)
279279
assert users[0].name == "Cassie", users
280280
assert failures == []
281281

0 commit comments

Comments
 (0)