Skip to content

Commit 623a049

Browse files
committed
fix: assert on warning instead of ignore
1 parent edee0bc commit 623a049

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/test_user.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,23 +260,23 @@ def test_populate_groups(self) -> None:
260260
self.assertEqual("TableauExample", group_list[2].name)
261261
self.assertEqual("local", group_list[2].domain_name)
262262

263-
@pytest.mark.filterwarnings("ignore:This method is deprecated, use bulk_add instead")
264263
def test_get_usernames_from_file(self):
265264
with open(ADD_XML, "rb") as f:
266265
response_xml = f.read().decode("utf-8")
267266
with requests_mock.mock() as m:
268267
m.post(self.server.users.baseurl, text=response_xml)
269-
user_list, failures = self.server.users.create_from_file(USERNAMES)
268+
with pytest.warns(DeprecationWarning, match="This method is deprecated, use bulk_add instead"):
269+
user_list, failures = self.server.users.create_from_file(USERNAMES)
270270
assert user_list[0].name == "Cassie", user_list
271271
assert failures == [], failures
272272

273-
@pytest.mark.filterwarnings("ignore:This method is deprecated, use bulk_add instead")
274273
def test_get_users_from_file(self):
275274
with open(ADD_XML, "rb") as f:
276275
response_xml = f.read().decode("utf-8")
277276
with requests_mock.mock() as m:
278277
m.post(self.server.users.baseurl, text=response_xml)
279-
users, failures = self.server.users.create_from_file(USERS)
278+
with pytest.warns(DeprecationWarning, match="This method is deprecated, use bulk_add instead"):
279+
users, failures = self.server.users.create_from_file(USERS)
280280
assert users[0].name == "Cassie", users
281281
assert failures == []
282282

0 commit comments

Comments
 (0)