Fix for #1301 of duplicate default permission requests

gconklin · gconklin · commit 3fefcfabdfc6 · 2023-10-19T19:00:45.000Z
1. logging to the root logger isn't correct
2. the log line calls fetch_call() which makes a server request
3. retuns the results of fetch_call() which is never used anywhere

Removing these lines from _set_default_permissions makes it more
functionally equivalent to the above _set_permissions
diff --git a/tableauserverclient/models/project_item.py b/tableauserverclient/models/project_item.py
@@ -163,9 +163,6 @@ def _set_default_permissions(self, permissions, content_type):
             attr,
             permissions,
         )
-        fetch_call = getattr(self, attr)
-        logging.getLogger().info({"type": attr, "value": fetch_call()})
-        return fetch_call()
 
     @classmethod
     def from_response(cls, resp, ns) -> List["ProjectItem"]:

Original file line number	Diff line number	Diff line change
`@@ -163,9 +163,6 @@ def _set_default_permissions(self, permissions, content_type):`
`163`	`163`	`attr,`
`164`	`164`	`permissions,`
`165`	`165`	`)`
`166`		`- fetch_call = getattr(self, attr)`
`167`		`- logging.getLogger().info({"type": attr, "value": fetch_call()})`
`168`		`- return fetch_call()`
`169`	`166`
`170`	`167`	`@classmethod`
`171`	`168`	`def from_response(cls, resp, ns) -> List["ProjectItem"]:`