fix: SfBottomSheet theme customization #302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SfBottomSheet theme customization does not work following the doc: https://help.syncfusion.com/maui-toolkit/themes/keys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where SfBottomSheet theme customization was not working as documented. The root cause was missing SetDynamicResource calls for the Background and GrabberBackground properties in the ApplyThemeResources method.
Key Changes:
- Added
SetDynamicResourcecall forBackgroundPropertywith key "SfBottomSheetBackground" - Added
SetDynamicResourcecall forGrabberBackgroundPropertywith key "SfBottomSheetGrabberBackground"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SfBottomSheet theme customization does not work following the doc: https://help.syncfusion.com/maui-toolkit/themes/keys
Root Cause of the Issue
the code is outdated with doc
Description of Change
add the required code
Issues Fixed
The color of SfBottomSheet could not be modified by modifying theme resource
Fixes #
Tageting man branch
Screenshots
Before:
After: