feat: fixed clippy issues

Author: Alex Holmberg

src/agent/session/ui.rs

@@ -206,8 +206,7 @@ pub fn print_banner(session: &ChatSession) {
     // Show platform context (selected project/organization)
     if session.platform_session.is_project_selected() {
         println!(
-            "  {} {}: {}/{}",
-            "📦",
+            "  📦 {}: {}/{}",
             "Project".white(),
             session
                 .platform_session
@@ -223,12 +222,7 @@ pub fn print_banner(session: &ChatSession) {
                 .cyan()
         );
     } else {
-        println!(
-            "  {} {} {}",
-            "📦",
-            "Project:".white(),
-            "(none selected)".dimmed()
-        );
+        println!("  📦 {} {}", "Project:".white(), "(none selected)".dimmed());
         println!("     {} {}", "→".cyan(), "sync-ctl org list".dimmed());
     }
 

src/agent/tools/platform/deploy_service.rs

@@ -379,10 +379,10 @@ User: "deploy this service"
             .find(|c| c.service_name.eq_ignore_ascii_case(&service_name));
 
         // 5. Get environment info for display
-        let environments = match client.list_environments(&project_id).await {
-            Ok(envs) => envs,
-            Err(_) => Vec::new(),
-        };
+        let environments: Vec<crate::platform::api::types::Environment> = client
+            .list_environments(&project_id)
+            .await
+            .unwrap_or_default();
 
         // Resolve environment name for display
         let (resolved_env_id, resolved_env_name, is_production) =

src/agent/tools/platform/list_hetzner_availability.rs

@@ -210,17 +210,17 @@ This provides current data directly from Hetzner API - never use hardcoded/stati
         // Group server types by category for easier reading
         let shared_cpu: Vec<&serde_json::Value> = server_types_json
             .iter()
-            .filter(|s| s["id"].as_str().map_or(false, |id| id.starts_with("cx")))
+            .filter(|s| s["id"].as_str().is_some_and(|id| id.starts_with("cx")))
             .collect();
 
         let dedicated_cpu: Vec<&serde_json::Value> = server_types_json
             .iter()
-            .filter(|s| s["id"].as_str().map_or(false, |id| id.starts_with("ccx")))
+            .filter(|s| s["id"].as_str().is_some_and(|id| id.starts_with("ccx")))
             .collect();
 
         let performance: Vec<&serde_json::Value> = server_types_json
             .iter()
-            .filter(|s| s["id"].as_str().map_or(false, |id| id.starts_with("cpx")))
+            .filter(|s| s["id"].as_str().is_some_and(|id| id.starts_with("cpx")))
             .collect();
 
         let response = json!({

src/analyzer/context/health_detector.rs

@@ -9,7 +9,6 @@ use crate::analyzer::{
     DetectedTechnology, HealthEndpoint, HealthEndpointSource, TechnologyCategory,
 };
 use crate::common::file_utils::{is_readable_file, read_file_safe};
-use crate::error::Result;
 use regex::Regex;
 use std::path::Path;
 

src/analyzer/display/matrix_view.rs

@@ -2,7 +2,7 @@
 
 use crate::analyzer::display::{
     BoxDrawer, format_list_smart, format_ports_smart, get_color_adapter, get_terminal_width,
-    helpers::{add_confidence_bar_to_drawer, format_project_category, get_main_technologies},
+    helpers::{add_confidence_bar_to_drawer, format_project_category},
     smart_truncate, visual_width,
 };
 use crate::analyzer::{ArchitecturePattern, MonorepoAnalysis};

src/analyzer/docker_analyzer.rs

@@ -1359,7 +1359,7 @@ fn infer_default_port(base_image: &Option<String>) -> Option<u16> {
     // Extract image name without registry/tag
     let image_name = image_lower
         .split('/')
-        .last()
+        .next_back()
         .unwrap_or(&image_lower)
         .split(':')
         .next()

src/lib.rs

@@ -337,7 +337,7 @@ pub async fn run_command(
                                     );
                                 }
                                 OutputFormat::Table => {
-                                    println!("\n{:<40} {:<30} {}", "ID", "NAME", "DESCRIPTION");
+                                    println!("\n{:<40} {:<30} DESCRIPTION", "ID", "NAME");
                                     println!("{}", "-".repeat(90));
                                     for project in projects {
                                         let desc = if project.description.is_empty() {
@@ -542,7 +542,7 @@ pub async fn run_command(
                                     );
                                 }
                                 OutputFormat::Table => {
-                                    println!("\n{:<40} {:<30} {}", "ID", "NAME", "SLUG");
+                                    println!("\n{:<40} {:<30} SLUG", "ID", "NAME");
                                     println!("{}", "-".repeat(90));
                                     for org in orgs {
                                         let slug =

src/server/processor.rs

@@ -65,7 +65,6 @@ use rig::completion::{CompletionModel, CompletionResponse, Message as RigPromptM
 use serde::{Deserialize, Serialize};
 use std::sync::Arc;
 use syncable_ag_ui_core::ToolCallId;
-use syncable_ag_ui_core::state::StateManager;
 use tokio::sync::Mutex;
 
 /// Step status for generative UI progress display.

src/wizard/cloud_provider_data.rs

@@ -697,7 +697,7 @@ pub async fn get_recommended_server_type(
         })
         .filter(|st| {
             // If preferred location is set, only include types available there
-            preferred_location.map_or(true, |loc| st.available_in.contains(&loc.to_string()))
+            preferred_location.is_none_or(|loc| st.available_in.contains(&loc.to_string()))
         })
         .min_by(|a, b| a.price_monthly.partial_cmp(&b.price_monthly).unwrap())
 }
@@ -719,8 +719,8 @@ pub async fn find_best_region(
     // Sort by availability count, preferring specified zone
     let mut sorted_regions = regions;
     sorted_regions.sort_by(|a, b| {
-        let a_zone_match = preferred_zone.map_or(false, |z| a.network_zone == z);
-        let b_zone_match = preferred_zone.map_or(false, |z| b.network_zone == z);
+        let a_zone_match = preferred_zone.is_some_and(|z| a.network_zone == z);
+        let b_zone_match = preferred_zone.is_some_and(|z| b.network_zone == z);
 
         match (a_zone_match, b_zone_match) {
             (true, false) => std::cmp::Ordering::Less,

src/wizard/config_form.rs

@@ -441,10 +441,10 @@ fn collect_env_vars_manually() -> Vec<DeploymentSecretInput> {
             is_secret,
         });
 
-        let add_another = match Confirm::new("Add another?").with_default(false).prompt() {
-            Ok(v) => v,
-            Err(_) => false,
-        };
+        let add_another = Confirm::new("Add another?")
+            .with_default(false)
+            .prompt()
+            .unwrap_or_default();
 
         if !add_another {
             break;
@@ -567,13 +567,10 @@ fn collect_env_vars_from_file(
         );
     }
 
-    let confirm = match Confirm::new("Use these variables?")
+    let confirm = Confirm::new("Use these variables?")
         .with_default(true)
         .prompt()
-    {
-        Ok(v) => v,
-        Err(_) => false,
-    };
+        .unwrap_or_default();
 
     if confirm { secrets } else { Vec::new() }
 }