Add some return types

Author: tareqas

Cli/Application.php

@@ -69,7 +69,7 @@ public function getApi()
         return $this->api;
     }
 
-    public function getLongVersion()
+    public function getLongVersion(): string
     {
         $version = parent::getLongVersion().' by <comment>Symfony</comment>';
         $commit = '@git-commit@';
@@ -116,7 +116,7 @@ protected function getDefaultCommands(): array
         return $defaultCommands;
     }
 
-    protected function doRunCommand(Command $command, InputInterface $input, OutputInterface $output)
+    protected function doRunCommand(Command $command, InputInterface $input, OutputInterface $output): int
     {
         if (!$command instanceof LocalCommand\NeedConfigurationInterface) {
             return parent::doRunCommand($command, $input, $output);

Cli/Command/AnalysisCommand.php

@@ -20,7 +20,7 @@
 
 class AnalysisCommand extends Command implements NeedConfigurationInterface
 {
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('analysis')
@@ -32,7 +32,7 @@ protected function configure()
         ;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $api = $this->getApplication()->getApi();
         $analysis = $api->getProject($input->getArgument('project-uuid'))->getLastAnalysis();

Cli/Command/AnalyzeCommand.php

@@ -22,7 +22,7 @@
 
 class AnalyzeCommand extends Command implements NeedConfigurationInterface
 {
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('analyze')
@@ -38,7 +38,7 @@ protected function configure()
         ;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $projectUuid = $input->getArgument('project-uuid');
 

Cli/Command/ConfigureCommand.php

@@ -17,16 +17,18 @@
 
 class ConfigureCommand extends Command
 {
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('configure')
             ->setDescription('(Re-)Configure your credentials.')
         ;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->getHelperSet()->get('configuration')->updateConfigurationManually($input, $output);
+
+        return 0;
     }
 }

Cli/Command/ProjectsCommand.php

@@ -18,15 +18,15 @@
 
 class ProjectsCommand extends Command implements NeedConfigurationInterface
 {
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('projects')
             ->setDescription('List all your projects')
         ;
     }
 
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $api = $this->getApplication()->getApi();
 
@@ -58,5 +58,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ->setRows($rows)
             ->render()
         ;
+
+        return 0;
     }
 }

Cli/Command/SelfUpdateCommand.php

@@ -25,7 +25,7 @@ class SelfUpdateCommand extends Command
     /**
      * {@inheritdoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('self-update')
@@ -44,7 +44,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $remoteFilename = 'http://get.insight.sensiolabs.com/insight.phar';
         $localFilename = $_SERVER['argv'][0];
@@ -57,7 +57,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $output->writeln('<info>insight is already up to date.</info>');
                 unlink($tempFilename);
 
-                return;
+                return 0;
             }
 
             chmod($tempFilename, 0777 & ~umask());
@@ -69,13 +69,17 @@ protected function execute(InputInterface $input, OutputInterface $output)
             rename($tempFilename, $localFilename);
 
             $output->writeln('<info>insight updated.</info>');
+
+            return 0;
         } catch (\Exception $e) {
             if (!$e instanceof \UnexpectedValueException && !$e instanceof \PharException) {
                 throw $e;
             }
             unlink($tempFilename);
             $output->writeln('<error>The download is corrupt ('.$e->getMessage().').</error>');
             $output->writeln('<error>Please re-run the self-update command to try again.</error>');
+
+            return 1;
         }
     }
 }

Cli/Helper/ConfigurationHelper.php

@@ -62,7 +62,7 @@ public function getConfiguration(InputInterface $input, OutputInterface $output)
         return $configuration;
     }
 
-    public function getName()
+    public function getName(): string
     {
         return 'configuration';
     }

Cli/Helper/DescriptorHelper.php

@@ -61,7 +61,7 @@ public function register($format, AbstractDescriptor $descriptor)
     /**
      * {@inheritdoc}
      */
-    public function getName()
+    public function getName(): string
     {
         return 'descriptor';
     }

Cli/Helper/FailConditionHelper.php

@@ -69,7 +69,7 @@ public function evaluate(Analysis $analysis, $expr)
         return 0;
     }
 
-    public function getName()
+    public function getName(): string
     {
         return 'fail_condition';
     }