minor #15172 [Validator] Add warning about closure not being cachable (Nyholm)

javiereguiluz · javiereguiluz · commit c09eacc24c99 · 2021-03-31T13:15:53.000+02:00
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Validator] Add warning about closure not being cachable Follow up from symfony/symfony#40645 The annotation cache will not work with `Closure`. If I understand correctly, it is not possible to have external dependencies in your custom validator AND get your annotation cached. You have to chose one or the other. Commits ------- ebddb78 [Validator] Add warning about closure not being cachable
diff --git a/reference/constraints/Callback.rst b/reference/constraints/Callback.rst
@@ -251,6 +251,13 @@ constructor of the Callback constraint::
         }
     }
 
+.. warning::
+
+    Using a ``Closure`` together with annotation configuration will disable the
+    annotation cache for that class/property/methods because ``Closure``s cannot
+    be cached. For best performance, it is recommended to use a static callback
+    method.
+
 Options
 -------
 

Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,13 @@ constructor of the Callback constraint::`
`251`	`251`	`}`
`252`	`252`	`}`
`253`	`253`
	`254`	`+.. warning::`
	`255`	`+`
	`256`	+ Using a ``Closure`` together with annotation configuration will disable the
	`257`	+ annotation cache for that class/property/methods because ``Closure``s cannot
	`258`	`+ be cached. For best performance, it is recommended to use a static callback`
	`259`	`+ method.`
	`260`	`+`
`254`	`261`	`Options`
`255`	`262`	`-------`
`256`	`263`