Commit 330ce77
committed
minor #9445 Server version should be specified as a string (kalifg, javiereguiluz)
This PR was merged into the 2.7 branch.
Discussion
----------
Server version should be specified as a string
If the server version is specified without quotes like this:
```yml
server_version: 5.6
```
The resulting compiled container will contain the value
```php
->createConnection(
...
'serverVersion' => 5.5999999999999996447286321199499070644378662109375,
...
)
```
This is a result of floating-point representation issues. Quoting the value will avoid that and will deliver the string `'5.6'` to the `version_compare` function, as it's expecting.
<!--
If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).
If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).
-->
Commits
-------
f525f75 Minor reword
8e50933 Server version should be specified as a string1 file changed
+6
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
312 | 312 | | |
313 | 313 | | |
314 | 314 | | |
315 | | - | |
| 315 | + | |
316 | 316 | | |
317 | 317 | | |
318 | 318 | | |
| |||
362 | 362 | | |
363 | 363 | | |
364 | 364 | | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
365 | 370 | | |
366 | 371 | | |
367 | 372 | | |
| |||
0 commit comments