feature #35167 [Notifier] Remove superfluous parameters in *Message::fromNotification() (fancyweb)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Notifier] Remove superfluous parameters in *Message::fromNotification()

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Those classes are final so I think we don't need those extra arguments.

Commits
-------

d0dacf51e1 [Notifier] Remove superfluous parameters in *Message::fromNotification()

Author: fabpot

CHANGELOG.md

@@ -1,6 +1,14 @@
 CHANGELOG
 =========
 
+5.1.0
+-----
+
+* [BC BREAK] The `ChatMessage::fromNotification()` method's `$recipient` and `$transport`
+  arguments were removed.
+* [BC BREAK] The `EmailMessage::fromNotification()` and `SmsMessage::fromNotification()`
+  methods' `$transport` argument was removed.
+
 5.0.0
 -----
 

Channel/ChatChannel.php

@@ -36,7 +36,7 @@ public function notify(Notification $notification, Recipient $recipient, string
         }
 
         if (null === $message) {
-            $message = ChatMessage::fromNotification($notification, $recipient, $transportName);
+            $message = ChatMessage::fromNotification($notification);
         }
 
         $message->transport($transportName);

Channel/SmsChannel.php

@@ -32,7 +32,7 @@ public function notify(Notification $notification, Recipient $recipient, string
         }
 
         if (null === $message) {
-            $message = SmsMessage::fromNotification($notification, $recipient, $transportName);
+            $message = SmsMessage::fromNotification($notification, $recipient);
         }
 
         if (null !== $transportName) {

Message/ChatMessage.php

@@ -12,7 +12,6 @@
 namespace Symfony\Component\Notifier\Message;
 
 use Symfony\Component\Notifier\Notification\Notification;
-use Symfony\Component\Notifier\Recipient\Recipient;
 
 /**
  * @author Fabien Potencier <fabien@symfony.com>
@@ -32,7 +31,7 @@ public function __construct(string $subject, MessageOptionsInterface $options =
         $this->options = $options;
     }
 
-    public static function fromNotification(Notification $notification, Recipient $recipient, string $transport = null): self
+    public static function fromNotification(Notification $notification): self
     {
         $message = new self($notification->getSubject());
         $message->notification = $notification;

Message/EmailMessage.php

@@ -35,7 +35,7 @@ public function __construct(RawMessage $message, Envelope $envelope = null)
         $this->envelope = $envelope;
     }
 
-    public static function fromNotification(Notification $notification, Recipient $recipient, string $transport = null): self
+    public static function fromNotification(Notification $notification, Recipient $recipient): self
     {
         if (!class_exists(NotificationEmail::class)) {
             $email = (new Email())

Message/SmsMessage.php

@@ -34,7 +34,7 @@ public function __construct(string $phone, string $subject)
         $this->phone = $phone;
     }
 
-    public static function fromNotification(Notification $notification, Recipient $recipient, string $transport = null): self
+    public static function fromNotification(Notification $notification, Recipient $recipient): self
     {
         if (!$recipient instanceof SmsRecipientInterface) {
             throw new LogicException(sprintf('To send a SMS message, "%s" should implement "%s" or the recipient should implement "%s".', \get_class($notification), SmsNotificationInterface::class, SmsRecipientInterface::class));