[Platform] Centralize default model clients and converters for OpenAI based standards #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
added
Platform
OskarStark
reviewed
Nov 22, 2025
chr-hertel
force-pushed
the
default-platform
branch
2 times, most recently
from
ef1d230 to
8d30c6a
Compare
chr-hertel
added
BC Break
Member
Author
|
Alternative namespace structure could be
|
chr-hertel
force-pushed
the
default-platform
branch
3 times, most recently
from
750c161 to
6cfa831
Compare
chr-hertel
force-pushed
the
default-platform
branch
from
6cfa831 to
2a92d13
Compare
OskarStark
added a commit
that referenced
this pull request
Nov 25, 2025
This PR was merged into the main branch. Discussion ---------- Ease LiteLLM setup for examples | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Trying to get this started as example for #938. `@welcoMattic` does that make sense to you? was just wondering if there's a different way than another postgres container Commits ------- 67637b9 Ease LiteLLM setup for examples
Contributor
I like the current structure in the PR (and not the suggestion). Keep in mind, that the Completions API is "old" and the new Responses API would be the "next" one, that need to fit in the namespace structure. Perhaps it is easier to understand, if there is NO "Responses" folder directly in the platform component, because this sound very general. I would prefer ...
instead of...
Additionally, in the suggested approach all classes would have the same name again (without namespace), and when the namespaces are imported in the concrete implementations, it's not immediately clear which object is currently being used (#autocomplete). There are already issues related to "all classes have the same name" #926 I'm really looking forward to seeing this patch in the component :) - independent of the class name structure :) |
3 tasks
OskarStark
added a commit
that referenced
this pull request
Dec 7, 2025
…ai embeddings- and completions-based platforms (chr-hertel) This PR was merged into the main branch. Discussion ---------- [Platform][Generic] Introduce generic platform for openai embeddings- and completions-based platforms | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | yes | Issues | Fix #114 | License | MIT Replaces #938 and unblocks #871 - diff looks a bit weird due to git mixing up removed classes and new generic bridge. - [x] Tests - [x] Docs - [x] Bundle This enables to use tools like Litellm without specific bridge with a configuration like this: ```yaml # config/packages/ai.yaml ai: platform: generic: litellm: base_url: '%env(LITELLM_HOST_URL)%' # e.g. http://localhost:4000 api_key: '%env(LITELLM_API_KEY)%' # e.g. sk-1234 model_catalog: 'Symfony\AI\Platform\Bridge\Generic\ModelCatalog' # see below agent: test: platform: 'ai.platform.generic.litellm' model: 'mistral-small-latest' tools: false services: Symfony\AI\Platform\Bridge\Generic\ModelCatalog: $models: mistral-small-latest: class: 'Symfony\AI\Platform\Bridge\Generic\CompletionsModel' capabilities: - !php/const 'Symfony\AI\Platform\Capability::INPUT_MESSAGES' - !php/const 'Symfony\AI\Platform\Capability::OUTPUT_TEXT' - !php/const 'Symfony\AI\Platform\Capability::OUTPUT_STREAMING' - !php/const 'Symfony\AI\Platform\Capability::OUTPUT_STRUCTURED' - !php/const 'Symfony\AI\Platform\Capability::INPUT_IMAGE' - !php/const 'Symfony\AI\Platform\Capability::TOOL_CALLING' ``` <img width="1216" height="635" alt="image" src="https://github.com/user-attachments/assets/7984afb3-40f9-454f-9d3d-6abdba1c828a" /> Commits ------- a42f298 Introduce generic platform for openai embeddings- and completions-based platforms
Member
Author
|
Closed in favor of #1052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a short term solution for this issue to unblock merging #871 without destroying a couple of bridges that are currently coupled to that "de facto standard" of OpenAI-based contracts.
This also will make it more obvious that our current ModelCatalog + Model class + neglected Capabilities need some love.
Introducing
Symfony\AI\Platform\Model\CompletionsModelandSymfony\AI\Platform\Model\EmbeddingsModelResultConverterInterfaceinto newSymfony\AI\ResultConverternamespaceModelClientInterfaceinto newSymfony\AI\ModelClientnamespaceSymfony\AI\Platform\ModelClient\CompletionsModelClientSymfony\AI\Platform\ModelClient\EmbeddingsModelClientSymfony\AI\Platform\ResultConverter\CompletionsResultConverterSymfony\AI\Platform\ResultConverter\EmbeddingsResultConverterLeads to removal of unspecific usage of OpenAI bridge implementations and basic Model subclasses in favor of specific ones if possible.