[Store][ChromaDb] Split store as dedicated package #1049
Merged
+262
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
OskarStark
force-pushed
the
chromadb-store-bridge
branch
3 times, most recently
from
ee6b791 to
53d5e95
Compare
OskarStark
changed the title
OskarStark
commented
Dec 5, 2025
OskarStark
force-pushed
the
chromadb-store-bridge
branch
2 times, most recently
from
6c54a05 to
318e026
Compare
Contributor
|
@OskarStark nice to split, but what about #1012 |
OskarStark
force-pushed
the
chromadb-store-bridge
branch
from
318e026 to
9792e95
Compare
Contributor
Author
|
Final review from @chr-hertel needed, otherwise we need to rebase afterwards 👍🏻 |
chr-hertel
reviewed
Dec 5, 2025
Comment on lines
-31
to
-33
| if (!class_exists(Client::class)) { | ||
| throw new RuntimeException('For using the ChromaDB as retrieval vector store, the codewithkyrian/chromadb-php package is required. Try running "composer require codewithkyrian/chromadb-php".'); | ||
| } |
Contributor
Author
|
Will fix the deptrac stuff and would like to get the confirmation for the package name from @fabpot, then good to merge Edit: |
OskarStark
force-pushed
the
chromadb-store-bridge
branch
5 times, most recently
from
1737410 to
9c7d148
Compare
OskarStark
commented
Dec 7, 2025
| - PlatformComponent | ||
| ChromaDbStore: | ||
| - StoreComponent | ||
| - PlatformComponent |
Contributor
Author
There was a problem hiding this comment.
Because of Vector class
OskarStark
force-pushed
the
chromadb-store-bridge
branch
3 times, most recently
from
edff4c8 to
bda7191
Compare
OskarStark
force-pushed
the
chromadb-store-bridge
branch
5 times, most recently
from
fbac1ce to
7d7c5ff
Compare
chr-hertel
approved these changes
Dec 7, 2025
chr-hertel
force-pushed
the
chromadb-store-bridge
branch
from
7d7c5ff to
2cc2d42
Compare
Member
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how tools were split in the Agent component, this extracts the ChromaDb store into its own standalone package.