Skip to content

[Platform][Gemini] Fix ResultConverter to handle gemini-2.5-flash multi-part thinking responses #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TNAJanssen wants to merge 1 commit into
base: main
Choose a base branch
from
+43 −1
Open

[Platform][Gemini] Fix ResultConverter to handle gemini-2.5-flash multi-part thinking responses #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/platform/src/Bridge/Gemini/Gemini/ResultConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,20 @@ private function convertChoice(array $choice): ToolCallResult|TextResult|BinaryR
}
}

// Fallback for multi-part text responses (e.g., thinking + response)
if ('' === $content) {
foreach ($contentParts as $contentPart) {
if (isset($contentPart['text'])) {
$content .= $contentPart['text'];
}
}
}

if ('' !== $content) {
return new TextResult($content);
}

throw new RuntimeException('Code execution failed.');
throw new RuntimeException('Response does not contain any text content.');
}

/**
Expand Down
33 changes: 33 additions & 0 deletions src/platform/tests/Bridge/Gemini/Gemini/ResultConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use Symfony\AI\Platform\Exception\RuntimeException;
use Symfony\AI\Platform\Result\BinaryResult;
use Symfony\AI\Platform\Result\RawHttpResult;
use Symfony\AI\Platform\Result\TextResult;
use Symfony\AI\Platform\Result\ToolCall;
use Symfony\AI\Platform\Result\ToolCallResult;
use Symfony\Contracts\HttpClient\ResponseInterface;
Expand Down Expand Up @@ -132,4 +133,36 @@ public function testConvertsInlineDataWithoutMimeTypeToBinaryResult()
$this->assertSame('base64EncodedData', $result->getContent());
$this->assertNull($result->getMimeType());
}

public function testConvertsMultiPartThinkingResponseToTextResult()
{
$converter = new ResultConverter();
$httpResponse = self::createMock(ResponseInterface::class);
$httpResponse->method('getStatusCode')->willReturn(200);
$httpResponse->method('toArray')->willReturn([
'candidates' => [
[
'content' => [
'parts' => [
[
'text' => '<analysis>This is the thinking process...</analysis>',
'thoughtSignature' => 'base64-encoded-signature...',
],
[
'text' => '```json\n{"result": "actual response"}\n```',
],
],
],
'finishReason' => 'STOP',
],
],
]);

$result = $converter->convert(new RawHttpResult($httpResponse));
$this->assertInstanceOf(TextResult::class, $result);
$this->assertSame(
'<analysis>This is the thinking process...</analysis>```json\n{"result": "actual response"}\n```',
$result->getContent()
);
}
}
Loading