Tracks removal of the workaround introduced in #760.
Context
A zero-parameter async throws(JSException) export generates a captureless _bjs_makePromise body closure, which lowers via thin_to_thick_function and miscompiles on Wasm (swiftlang/swift#89320): the thrown error is corrupted across the async unwind, trapping in Promise_reject or rejecting with a garbage value. #760 works around this at the codegen level by forcing a capture in the emitted body closure (the capture must also be read in the body, since an unread capture list entry is dropped by capture analysis and the closure stays thin):
let __bjs_capture = 0
return _bjs_makePromise(resolve: Promise_resolve_SS, reject: Promise_reject) { [__bjs_capture] () async throws(JSException) -> String in
_ = __bjs_capture
return try await ping()
}
What to do once the compiler fix ships
The proper fix is swiftlang/swift#89715 (IRGen: fix async typed throws miscompiles on Wasm). Once it is available in the oldest Swift toolchain JavaScriptKit supports:
- Remove
asyncThrowsBodyForcesCapture and the forced-capture emission from ExportedThunkBuilder in Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift.
- Regenerate snapshots and the AoT-committed bindings.
- Keep the
zeroArgAsyncThrows end-to-end regression test as the guard that the reject path still works without the workaround.
Tracks removal of the workaround introduced in #760.
Context
A zero-parameter
async throws(JSException)export generates a captureless_bjs_makePromisebody closure, which lowers viathin_to_thick_functionand miscompiles on Wasm (swiftlang/swift#89320): the thrown error is corrupted across the async unwind, trapping inPromise_rejector rejecting with a garbage value. #760 works around this at the codegen level by forcing a capture in the emitted body closure (the capture must also be read in the body, since an unread capture list entry is dropped by capture analysis and the closure stays thin):What to do once the compiler fix ships
The proper fix is swiftlang/swift#89715 (IRGen: fix async typed throws miscompiles on Wasm). Once it is available in the oldest Swift toolchain JavaScriptKit supports:
asyncThrowsBodyForcesCaptureand the forced-capture emission fromExportedThunkBuilderinPlugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift.zeroArgAsyncThrowsend-to-end regression test as the guard that the reject path still works without the workaround.