debug: fallback to mark breakpoints verified on stopped/breakpoint events #1989
+98
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanthatdoescares
requested review from
0xTim,
adam-fowler and
award999
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LLDB-DAP sometimes fails to mark breakpoints as verified in the
setBreakpointsresponse, even though the breakpoint is hit during debugging. This leads to the VS Code UI showing the breakpoint as “unverified” while execution actually stops there.This PR adds a safe fallback that marks breakpoints as verified when we detect them being hit via:
stoppedevent withreason: "breakpoint", orbreakpointevent containing a valid source and line.This improves consistency between actual debugger behavior and the UI, especially for Swift executables and
swift test.Issue: #1871
Tasks