Re-enable Windows CI for Swift 6.2.1 (#1963)

Author: matthewbastien

.github/workflows/nightly.yml

@@ -114,5 +114,3 @@ jobs:
       windows_pre_build_command: . .github\workflows\scripts\windows\setup.ps1
       windows_build_command: Invoke-Program scripts\test_windows.ps1
       enable_windows_docker: false
-      # TODO re-enable when 6.2.1 toolchain working
-      enable_windows_checks: false

.github/workflows/pull_request.yml

@@ -64,7 +64,7 @@ jobs:
       linux_pre_build_command: . .github/workflows/scripts/setup-linux.sh
       linux_build_command: ./scripts/test.sh
       # Windows
-      windows_exclude_swift_versions: "${{ contains(github.event.pull_request.labels.*.name, 'full-test-run') && '[{\"swift_version\": \"nightly-6.1\"},{\"swift_version\": \"nightly\"},{\"swift_version\": \"6.2\"}]' || '[{\"swift_version\": \"nightly-6.1\"},{\"swift_version\": \"nightly-6.2\"},{\"swift_version\": \"nightly\"}]' }}"
+      windows_exclude_swift_versions: "${{ contains(github.event.pull_request.labels.*.name, 'full-test-run') && '[{\"swift_version\": \"nightly-6.1\"},{\"swift_version\": \"nightly\"}]' || '[{\"swift_version\": \"nightly-6.1\"},{\"swift_version\": \"nightly-6.2\"},{\"swift_version\": \"nightly\"}]' }}"
       windows_env_vars: |
         CI=1
         FAST_TEST_RUN=${{ contains(github.event.pull_request.labels.*.name, 'full-test-run') && '0' || '1'}}

.github/workflows/scripts/windows/setup.ps1

@@ -2,16 +2,11 @@
 . .github\workflows\scripts\windows\install-nodejs.ps1
 
 # Download the VSIX archived upstream
-npm ci
+npm ci --ignore-scripts
 $Process = Start-Process npx "tsx scripts/download_vsix.ts" -Wait -PassThru -NoNewWindow
 if ($Process.ExitCode -eq 0) {
     Write-Host 'SUCCESS'
 } else {
     Write-Host  ('FAILED ({0})' -f $Process.ExitCode)
     exit 1
 }
-
-Get-Content $env:GITHUB_ENV | foreach {
-    $name, $value = $_.split('=')
-    Set-Content env:\$name $value
-}

test/integration-tests/debugger/lldb.test.ts

@@ -15,7 +15,6 @@ import { expect } from "chai";
 
 import { WorkspaceContext } from "@src/WorkspaceContext";
 import { getLLDBLibPath } from "@src/debugger/lldb";
-import { Version } from "@src/utilities/version";
 
 import { activateExtensionForTest } from "../utilities/testutilities";
 
@@ -24,16 +23,6 @@ suite("lldb contract test suite", () => {
 
     activateExtensionForTest({
         async setup(ctx) {
-            // This test is failing due to toolchain issues starting with Swift 6.2.1
-            // Will re-enable once that is resolved.
-            //
-            // https://github.com/swiftlang/vscode-swift/issues/1947
-            if (
-                process.platform === "win32" &&
-                ctx.globalToolchainSwiftVersion.isGreaterThanOrEqual(new Version(6, 2, 1))
-            ) {
-                this.skip();
-            }
             workspaceContext = ctx;
         },
         requiresDebugger: true,