[Sema] Consider modules imported from more paths as private

Consider both frameworks and free floating modules imported from more
private path as SPI. This will make the compiler raise errors on public
imports of more private modules.

rdar://91904154

Author: xymus

lib/AST/Module.cpp

@@ -2646,16 +2646,18 @@ ModuleLibraryLevelRequest::evaluate(Evaluator &evaluator,
   auto fromPrivateFrameworks = [&](StringRef modulePath) -> bool {
     if (!ctx.LangOpts.Target.isOSDarwin()) return false;
 
-    return hasSDKPrefix(modulePath, "System", "Library", "PrivateFrameworks");
+    return hasSDKPrefix(modulePath, "AppleInternal", "Library", "Frameworks") ||
+           hasSDKPrefix(modulePath, "System", "Library", "PrivateFrameworks") ||
+           hasSDKPrefix(modulePath, "System", "iOSSupport", "System", "Library", "PrivateFrameworks") ||
+           hasSDKPrefix(modulePath, "usr", "local", "include");
   };
 
   if (module->isNonSwiftModule()) {
     if (auto *underlying = module->findUnderlyingClangModule()) {
       // Imported clangmodules are SPI if they are defined by a private
       // modulemap or from the PrivateFrameworks folder in the SDK.
       bool moduleIsSPI = underlying->ModuleMapIsPrivate ||
-                         (underlying->isPartOfFramework() &&
-                          fromPrivateFrameworks(underlying->PresumedModuleMapFile));
+                         fromPrivateFrameworks(underlying->PresumedModuleMapFile);
       return moduleIsSPI ? LibraryLevel::SPI : LibraryLevel::API;
     }
     return LibraryLevel::Other;

test/Sema/Inputs/public-private-sdk/usr/local/include/LocalClang.h

@@ -0,0 +1 @@
+// Empty

test/Sema/Inputs/public-private-sdk/usr/local/include/module.modulemap

@@ -0,0 +1,4 @@
+module LocalClang [system] {
+  header "LocalClang.h"
+  export *
+}

test/Sema/implementation-only-import-suggestion.swift

@@ -40,6 +40,7 @@ import PrivateSwift // expected-error{{private module 'PrivateSwift' is imported
 import PublicClang
 import PublicClang_Private // expected-error{{private module 'PublicClang_Private' is imported publicly from the public module 'MainLib'}}
 import FullyPrivateClang // expected-error{{private module 'FullyPrivateClang' is imported publicly from the public module 'MainLib'}}
+import LocalClang // expected-error{{private module 'LocalClang' is imported publicly from the public module 'MainLib'}}
 @_exported import MainLib // expected-warning{{private module 'MainLib' is imported publicly from the public module 'MainLib'}}
 
 /// Expect no errors with implementation-only imports.
@@ -51,6 +52,7 @@ import FullyPrivateClang // expected-error{{private module 'FullyPrivateClang' i
 @_implementationOnly import PrivateSwift
 @_implementationOnly import PublicClang_Private
 @_implementationOnly import FullyPrivateClang
+@_implementationOnly import LocalClang
 
 #endif