The asserts in preprocessQueue assume that the only reason we are

preprocessing is due to running into a concurrent enqueuer while
draining. However, sometimes we can go into this code path because
compare_exchange_weak failed spuriously. We need to account the fact
that compare_exchange_weak can fail spuriously. Also add more asserts.

Radar-Id: rdar://problem/89236911

Author: rokhinip

stdlib/public/Concurrency/Actor.cpp

@@ -1031,6 +1031,8 @@ static Job *
 preprocessQueue(JobRef unprocessedStart, JobRef unprocessedEnd, Job *existingProcessedJobsToMergeInto)
 {
   assert(existingProcessedJobsToMergeInto != NULL);
+  assert(unprocessedStart.needsPreprocessing());
+  assert(unprocessedStart.getAsJob() != unprocessedEnd.getAsJob());
 
   // Build up a list of jobs we need to preprocess
   using ListMerger = swift::ListMerger<Job*, JobQueueTraits>;
@@ -1423,6 +1425,11 @@ Job * DefaultActorImpl::drainOne() {
       return firstJob;
     }
 
+    // We failed the weak cmpxchg spuriously, go through loop again.
+    if (oldState.getFirstJob().getAsJob() == jobToPreprocessFrom.getAsJob()) {
+      continue;
+    }
+
     // There were new items concurrently added to the queue. We need to
     // preprocess the newly added unprocessed items and merge them to the already
     // preprocessed list.