NFC: explain the missingInverses

kavon · kavon · commit 761502fabec6 · 2025-12-02T18:00:02.000-08:00
diff --git a/lib/AST/RequirementMachine/RequirementMachineRequests.cpp b/lib/AST/RequirementMachine/RequirementMachineRequests.cpp
@@ -451,7 +451,9 @@ RequirementSignatureRequest::evaluate(Evaluator &evaluator,
       }
     }
 
-    // FIXME: We don't have the inverses from desugaring available here!
+    // FIXME: We should pass proto->getInverseRequirements() instead of
+    //        an empty vector, but this makes the requirement machine angry.
+    //        For now, we check them in `checkProtocolRefinementRequirements`.
     SmallVector<InverseRequirement, 2> missingInverses;
 
     // Diagnose redundant requirements and conflicting requirements.

Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,9 @@ RequirementSignatureRequest::evaluate(Evaluator &evaluator,`
`451`	`451`	`}`
`452`	`452`	`}`
`453`	`453`
`454`		`- // FIXME: We don't have the inverses from desugaring available here!`
	`454`	`+ // FIXME: We should pass proto->getInverseRequirements() instead of`
	`455`	`+ // an empty vector, but this makes the requirement machine angry.`
	`456`	+ // For now, we check them in `checkProtocolRefinementRequirements`.
`455`	`457`	`SmallVector<InverseRequirement, 2> missingInverses;`
`456`	`458`
`457`	`459`	`// Diagnose redundant requirements and conflicting requirements.`