Skip to content

[Swift Build] Wire up --jobs #9367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
owenv wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Swift Build] Wire up --jobs #9367

owenv wants to merge 2 commits into from
+47 −3

Conversation

@owenv
Copy link
Contributor

@owenv owenv commented Nov 12, 2025 •
edited by bkhouri
Loading

Adopt the new API on SWBBuildRequest

Depends on #9417
Fixes: #9321

@owenv
Copy link
Contributor Author

owenv commented Nov 12, 2025

Closes #9321

@owenv
Copy link
Contributor Author

owenv commented Nov 12, 2025

@swift-ci test

@owenv
Copy link
Contributor Author

owenv commented Nov 12, 2025

@swift-ci test

bkhouri
bkhouri requested changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@bkhouri bkhouri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it may be benign, but can we add an automated test against the makeBuildSystem that ensure the SWBBuildRequest has the correct value set vain the various buildParmeters.workers value?

@bkhouri
Copy link
Contributor

bkhouri commented Dec 5, 2025

@swift-ci test

@bkhouri bkhouri marked this pull request as draft December 5, 2025 05:21
@bkhouri
Copy link
Contributor

bkhouri commented Dec 5, 2025

I know it may be benign, but can we add an automated test against the makeBuildSystem that ensure the SWBBuildRequest has the correct value set vain the various buildParmeters.workers value?

Test has been added.

@bkhouri bkhouri self-assigned this Dec 5, 2025
@bkhouri
Copy link
Contributor

bkhouri commented Dec 9, 2025

@swift-ci test

@bkhouri bkhouri marked this pull request as ready for review December 9, 2025 14:53
@bkhouri
Copy link
Contributor

bkhouri commented Dec 9, 2025

@swift-ci test windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@bkhouri bkhouri bkhouri approved these changes

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 is a code owner

Assignees

@bkhouri bkhouri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Parity] Pass the --jobs to SwiftBuild

3 participants

@owenv @bkhouri @jakepetroules