[lldb][windows] add NSDate and FoundationEssentials.Date dataformatters

Author: charles-zablit

lldb/source/Plugins/Language/Swift/FoundationValueTypes.cpp

@@ -37,6 +37,13 @@ bool lldb_private::formatters::swift::Date_SummaryProvider(
 
   ValueObjectSP time_sp(valobj.GetChildAtNamePath({g__time}));
 
+#ifdef _WIN32
+  static ConstString g__timeIntervalSinceReferenceDate(
+      "_timeIntervalSinceReferenceDate");
+  if (!time_sp)
+    time_sp = valobj.GetChildAtNamePath({g__time});
+#endif
+
   if (!time_sp)
     return false;
 

lldb/source/Plugins/Language/Swift/SwiftLanguage.cpp

@@ -670,8 +670,16 @@ LoadFoundationValueTypesFormatters(lldb::TypeCategoryImplSP swift_category_sp) {
 
   lldb_private::formatters::AddCXXSummary(
       swift_category_sp, lldb_private::formatters::swift::Date_SummaryProvider,
-      "Foundation.Date summary provider", ConstString("Foundation.Date"),
+      "Foundation.Date summary provider",
+      ConstString("Foundation(Essentials)?\\.Date"),
+      TypeSummaryImpl::Flags(summary_flags).SetDontShowChildren(true), true);
+
+#ifdef _WIN32
+  lldb_private::formatters::AddCXXSummary(
+      swift_category_sp, lldb_private::formatters::swift::Date_SummaryProvider,
+      "Foundation.NSDate summary provider", ConstString("Foundation.NSDate"),
       TypeSummaryImpl::Flags(summary_flags).SetDontShowChildren(true));
+#endif
 
   lldb_private::formatters::AddCXXSummary(
       swift_category_sp,

lldb/test/API/functionalities/data-formatter/swift/date/Makefile

@@ -0,0 +1,3 @@
+SWIFT_SOURCES := main.swift
+
+include Makefile.rules

lldb/test/API/functionalities/data-formatter/swift/date/TestSwiftDateFormatters.py

@@ -0,0 +1,34 @@
+"""
+Test Foundation.Date summary strings.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+
+import sys
+
+
+class TestCase(TestBase):
+    @swiftTest
+    def test_swift_date_formatters(self):
+        """Test Date summary strings."""
+        self.build()
+
+        _ = lldbutil.run_to_source_breakpoint(
+            self, "break here", lldb.SBFileSpec("main.swift")
+        )
+
+        self.expect(
+            "v date",
+            startstr="(Foundation.Date) date =",
+        )
+
+        if sys.platform != "win32":
+            return
+
+        self.expect(
+            "v nsdate",
+            startstr="(Foundation.NSDate) date =",
+        )

lldb/test/API/functionalities/data-formatter/swift/date/main.swift

@@ -0,0 +1,5 @@
+import Foundation
+
+let date = Date.now
+let nsdate = NSDate()
+print("break here")