Skip to content

Commit 263bf3c

Browse files
author
Andrew Goldis
authored
Prevent children rendering for collapsed nodes
The UI is sluggish for huge trees - even if a node is collapsed its children are rendered and hidden via CSS properties. Preventing them to render greatly improves responsiveness.
1 parent 6d48ca6 commit 263bf3c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

lib/node.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ var Node = React.createClass({
3030

3131
if(index.children && index.children.length) {
3232
var childrenStyles = {};
33-
if(index.node.collapsed) childrenStyles.display = 'none';
3433
childrenStyles['paddingLeft'] = this.props.paddingLeft + 'px';
3534

3635
return (
@@ -71,7 +70,7 @@ var Node = React.createClass({
7170
{this.renderCollapse()}
7271
{tree.renderNode(node)}
7372
</div>
74-
{this.renderChildren()}
73+
{node.collapsed ? null : this.renderChildren()}
7574
</div>
7675
);
7776
},

0 commit comments

Comments
 (0)