General clean up of formatting and clippy warnings (#28)

Author: jbangelo

src/ephemeris.rs

@@ -19,7 +19,7 @@ use std::fmt::{Display, Formatter};
 
 /// Number of bytes in  the Galileo INAV message
 // TODO(jbangelo) bindgen doesn't catch this variable on linux for some reason
-pub const GAL_INAV_CONTENT_BYTE: usize = ((128 + 8 - 1) / 8);
+pub const GAL_INAV_CONTENT_BYTE: usize = (128 + 8 - 1) / 8;
 
 /// An error indicating that the ephemeris is invalid
 #[derive(Copy, Clone, Debug)]
@@ -45,6 +45,8 @@ pub enum Status {
     FitIntervalEqualsZero = c_bindings::ephemeris_status_t_EPH_FIT_INTERVAL_EQ_0,
     Unhealthy = c_bindings::ephemeris_status_t_EPH_UNHEALTHY,
     TooOld = c_bindings::ephemeris_status_t_EPH_TOO_OLD,
+    InvalidSid = c_bindings::ephemeris_status_t_EPH_INVALID_SID,
+    InvalidIod = c_bindings::ephemeris_status_t_EPH_INVALID_IOD,
     Valid = c_bindings::ephemeris_status_t_EPH_VALID,
 }
 

src/lib.rs

@@ -32,7 +32,7 @@ impl Vec3 {
     }
 
     pub fn from_array(a: &[f64; 3]) -> Vec3 {
-        Vec3(a.clone())
+        Vec3(*a)
     }
 
     pub fn get_x(&self) -> f64 {

src/time.rs

@@ -94,16 +94,16 @@ impl GpsTime {
 impl fmt::Debug for GpsTime {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.debug_struct("GpsTime")
-            .field("WN", unsafe { &self.0.wn })
-            .field("TOW", unsafe { &self.0.tow })
+            .field("WN", &self.0.wn)
+            .field("TOW", &self.0.tow)
             .finish()
     }
 }
 
 impl PartialEq for GpsTime {
     fn eq(&self, other: &Self) -> bool {
         let diff_seconds = self.diff(other).abs();
-        return diff_seconds < Self::JIFFY;
+        diff_seconds < Self::JIFFY
     }
 }
 

src/troposphere.rs

@@ -28,7 +28,7 @@ mod tests {
 
     #[test]
     fn calc_troposphere() {
-        const d_tol: f64 = 1e-4;
+        const D_TOL: f64 = 1e-4;
 
         /* some tests against "true" values computed with UNB3M.f */
         /* http://www2.unb.ca/gge/Personnel/Santos/UNB_pack.pdf */
@@ -46,7 +46,7 @@ mod tests {
         let d_tropo = calc_delay(&t, lat, h, el);
 
         assert!(
-            (d_tropo - d_true).abs() < d_tol,
+            (d_tropo - d_true).abs() < D_TOL,
             "Distance didn't match hardcoded correct values {:.5}. Saw: {:.5}",
             d_true,
             d_tropo
@@ -64,7 +64,7 @@ mod tests {
         let d_tropo = calc_delay(&t, lat, h, el);
 
         assert!(
-            (d_tropo - d_true).abs() < d_tol,
+            (d_tropo - d_true).abs() < D_TOL,
             "Distance didn't match hardcoded correct values {:.5}. Saw: {:.5}",
             d_true,
             d_tropo
@@ -82,7 +82,7 @@ mod tests {
         let d_tropo = calc_delay(&t, lat, h, el);
 
         assert!(
-            (d_tropo - d_true).abs() < d_tol,
+            (d_tropo - d_true).abs() < D_TOL,
             "Distance didn't match hardcoded correct values {:.5}. Saw: {:.5}",
             d_true,
             d_tropo