Add check_attributes aspect [BUILD-638] (#63)

* Add check_attributes aspect [BUILD-638]

* Unify get_cc_srcs and get_cc_hdrs

Author: krisukox

check_attributes/BUILD.bazel

@@ -0,0 +1,9 @@
+filegroup(
+    name = "excluded_default",
+)
+
+label_flag(
+    name = "excluded",
+    build_setting_default = ":excluded_default",
+    visibility = ["//visibility:public"],
+)

check_attributes/check_attributes.bzl

@@ -0,0 +1,54 @@
+load("//tools:get_cc_files.bzl", "get_cc_files")
+
+def _run_check_attributes(ctx, infile):
+    output = ctx.actions.declare_file(infile.path + ".check-attributes.txt")
+
+    ctx.actions.run_shell(
+        inputs = [infile],
+        outputs = [output],
+        command = """
+            result=0
+
+            matches=$(grep -Hn __attribute__ "{infile}")
+
+            touch {output}
+
+            if [ -n "$matches" ];
+            then
+                while read -r line;
+                do
+                    echo "error: Do not use __attribute__, prefer one of the macros from swiftnav/macros.h" | tee {output}
+                    echo "$line" | tee {output}
+                    result=1
+                done <<< $matches
+            fi
+
+            exit $result
+        """.format(infile = infile.path, output = output.path),
+    )
+    return output
+
+def _check_attributes_impl(target, ctx):
+    # if not a C/C++ target, we are not interested
+    if not CcInfo in target:
+        return []
+
+    outputs = []
+
+    for file in get_cc_files(ctx):
+        if file in ctx.files._excluded:
+            continue
+        outputs.append(_run_check_attributes(ctx, file))
+
+    return [
+        OutputGroupInfo(report = depset(direct = outputs)),
+    ]
+
+check_attributes = aspect(
+    implementation = _check_attributes_impl,
+    fragments = ["cpp"],
+    attrs = {
+        "_excluded": attr.label(default = Label("//check_attributes:excluded")),
+    },
+    toolchains = ["@bazel_tools//tools/cpp:toolchain_type"],
+)

clang_format/clang_format_check.bzl

@@ -1,3 +1,5 @@
+load("//tools:get_cc_files.bzl", "get_cc_files")
+
 def _check_format(ctx, exe, config, infile, clang_format_bin):
     output = ctx.actions.declare_file(infile.path + ".clang-format.txt")
 
@@ -19,18 +21,6 @@ def _check_format(ctx, exe, config, infile, clang_format_bin):
     )
     return output
 
-def _extract_files(ctx):
-    files = []
-    if hasattr(ctx.rule.attr, "srcs"):
-        for src in ctx.rule.attr.srcs:
-            files += [src for src in src.files.to_list() if src.is_source]
-
-    if hasattr(ctx.rule.attr, "hdrs"):
-        for hdr in ctx.rule.attr.hdrs:
-            files += [hdr for hdr in hdr.files.to_list() if hdr.is_source]
-
-    return files
-
 def _clang_format_check_aspect_impl(target, ctx):
     # if not a C/C++ target, we are not interested
     if not CcInfo in target:
@@ -39,7 +29,7 @@ def _clang_format_check_aspect_impl(target, ctx):
     exe = ctx.attr._clang_format.files_to_run
     config = ctx.attr._clang_format_config.files.to_list()[0]
     clang_format_bin = ctx.attr._clang_format_bin.files.to_list()[0]
-    files = _extract_files(ctx)
+    files = get_cc_files(ctx)
 
     outputs = []
     for file in files:

clang_tidy/clang_tidy.bzl

@@ -1,5 +1,6 @@
 load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")
 load("//cc:defs.bzl", "BINARY", "LIBRARY")
+load("//tools:get_cc_files.bzl", "get_cc_srcs")
 
 def _flatten(input_list):
     return [item for sublist in input_list for item in sublist]
@@ -71,13 +72,6 @@ def _run_tidy(ctx, wrapper, exe, additional_deps, config, flags, compilation_con
     )
     return outfile
 
-def _rule_sources(ctx):
-    srcs = []
-    if hasattr(ctx.rule.attr, "srcs"):
-        for src in ctx.rule.attr.srcs:
-            srcs += [src for src in src.files.to_list() if src.is_source]
-    return srcs
-
 def _toolchain_flags(ctx):
     cc_toolchain = find_cpp_toolchain(ctx)
     feature_configuration = cc_common.configure_features(
@@ -142,7 +136,7 @@ def _clang_tidy_aspect_impl(target, ctx):
     final_flags = _replace_gendir(safe_flags, ctx)
     compilation_contexts = _get_compilation_contexts(target, ctx)
 
-    srcs = _rule_sources(ctx)
+    srcs = get_cc_srcs(ctx)
 
     # We exclude headers because we shouldn't run clang-tidy directly with them.
     # Headers will be linted if included in a source file.

tools/get_cc_files.bzl

@@ -6,41 +6,41 @@ FilesInfo = provider(
     },
 )
 
-def _get_hdrs(ctx):
-    files = []
+def get_cc_hdrs(ctx):
+    hdrs = []
 
     if hasattr(ctx.rule.attr, "hdrs"):
         for hdr in ctx.rule.attr.hdrs:
-            for file in hdr.files.to_list():
-                if not file.path.startswith(ctx.genfiles_dir.path):
-                    files.append(file)
-    return files
+            hdrs += [hdr for hdr in hdr.files.to_list() if hdr.is_source]
 
-def _get_srcs(ctx):
-    files = []
+    return hdrs
+
+def get_cc_srcs(ctx):
+    srcs = []
 
     if hasattr(ctx.rule.attr, "srcs"):
         for src in ctx.rule.attr.srcs:
-            for file in src.files.to_list():
-                if file.is_source and not file.path.startswith(ctx.genfiles_dir.path):
-                    files.append(file)
-    return files
+            srcs += [src for src in src.files.to_list() if src.is_source]
 
-def _get_cc_target_files_impl(target, ctx):
+    return srcs
+
+def get_cc_files(ctx):
     files = []
 
+    files.extend(get_cc_srcs(ctx))
+    files.extend(get_cc_hdrs(ctx))
+
+    return files
+
+def _get_cc_target_files_impl(target, ctx):
     if not CcInfo in target:
         return [FilesInfo(files = [])]
 
     tags = getattr(ctx.rule.attr, "tags", [])
     if not LIBRARY in tags and not TEST_LIBRARY in tags and not BINARY in tags:
         return [FilesInfo(files = [])]
 
-    files.extend(_get_srcs(ctx))
-
-    files.extend(_get_hdrs(ctx))
-
-    return [FilesInfo(files = files)]
+    return [FilesInfo(files = get_cc_files(ctx))]
 
 get_cc_target_files = aspect(
     implementation = _get_cc_target_files_impl,
@@ -50,7 +50,7 @@ def _get_cc_target_hdrs_impl(target, ctx):
     if not CcInfo in target:
         return [FilesInfo(files = [])]
 
-    return [FilesInfo(files = _get_hdrs(ctx))]
+    return [FilesInfo(files = get_cc_hdrs(ctx))]
 
 get_cc_target_hdrs = aspect(
     implementation = _get_cc_target_hdrs_impl,