fix bug, pr comments

Author: kovach

DEVELOPMENT.md

@@ -5,6 +5,7 @@ Follow these instructions if you intend to make changes to libswiftnav.
 
 Tools needed:
  * doxygen
+ * convert from ImageMagick
  * pip install gcovr diff-cover
 
 To get started, run::
@@ -16,4 +17,4 @@ This makes the directory if it doesn't already exist, runs cmake with `Coverage`
 inside it, and installs a git pre-commit hook that runs style and code-coverage checkers
 in this build directory. These checks require doxygen, gcovr, and diff-cover
 
-To manually run the coverage task, use `make coverage`. For syntax, use `make style`.
+To manually run the coverage task, use `make check-coverage`. For syntax, use `make check-style`.

checks/pre-commit

@@ -1,7 +1,3 @@
-set -e
 echo "precommit running. checking build located at ${subdir}."
-cd ${subdir}
-../checks/run-coverage.sh
-
-#echo "commit failed"
-exit 1
+cd "${subdir}"
+make check-coverage

checks/setup-hooks.sh

@@ -1,10 +1,10 @@
 # set up build directory
 builddir=${1:-build/} # by default use build/
 echo "Build directory: ${builddir}"
-mkdir -p $builddir
-( cd $builddir && cmake -DCMAKE_BUILD_TYPE=Coverage .. )
+mkdir -p "$builddir"
+( cd "$builddir" && cmake -DCMAKE_BUILD_TYPE=Coverage .. )
 
-hooks="`git rev-parse --git-dir`/hooks"
+hooks="$(git rev-parse --git-dir)/hooks"
 echo "Installing hook at: ${hooks}"
 # insert value of builddir as first line of pre-commit
 echo "subdir=$builddir" | cat - checks/pre-commit > "$hooks/pre-commit"

tests/CMakeLists.txt

@@ -73,7 +73,7 @@ else (CMAKE_CROSSCOMPILING)
       COMMAND ../checks/run-coverage.sh
       WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
     )
-    add_custom_target(coverage DEPENDS diffreport.html)
+    add_custom_target(check-coverage DEPENDS diffreport.html)
 
   endif (NOT CHECK_FOUND)
 endif (CMAKE_CROSSCOMPILING)