Skip to content

Fix/test session isolation and mocks #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishmistry36 wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −5
Open

Fix/test session isolation and mocks #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54fedd6
fix: prevent subclass shadowing of global HTTP session
ashishmistry36 May 19, 2026
e4a1719
test: mock network requests in live boxscore and odds url tests
ashishmistry36 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/nba_api/library/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,15 @@ class NBAHTTP:

@classmethod
def get_session(cls):
session = cls._session
session = NBAHTTP._session
if session is None:
session = requests.Session()
cls._session = session
NBAHTTP._session = session
return session

@classmethod
def set_session(cls, session) -> None:
cls._session = session
NBAHTTP._session = session

def clean_contents(self, contents):
return contents
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/live/endpoints/test_live_boxscore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ def send_api_request(
monkeypatch.setattr(NBAHTTP, "send_api_request", MockResponse.send_api_request)


def test_get_request_url():
def test_get_request_url(nba_http_patch):
assert (
boxscore.BoxScore(game_id).get_request_url()
== "https://cdn.nba.com/static/json/liveData/boxscore/boxscore_0022000180.json"
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/live/endpoints/test_live_odds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ def send_api_request(
monkeypatch.setattr(NBAHTTP, "send_api_request", MockResponse.send_api_request)


def test_get_request_url():
def test_get_request_url(nba_http_patch):
assert (
odds.Odds().get_request_url()
== "https://cdn.nba.com/static/json/liveData/odds/odds_todaysGames.json"
Expand Down