From 54fedd6afaf4d11fc20327cad3069908604f05f4 Mon Sep 17 00:00:00 2001 From: Ashish Mistry Date: Tue, 19 May 2026 16:54:11 -0400 Subject: [PATCH 1/2] fix: prevent subclass shadowing of global HTTP session --- src/nba_api/library/http.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nba_api/library/http.py b/src/nba_api/library/http.py index aeac18ee..fbfe3691 100644 --- a/src/nba_api/library/http.py +++ b/src/nba_api/library/http.py @@ -68,15 +68,15 @@ class NBAHTTP: @classmethod def get_session(cls): - session = cls._session + session = NBAHTTP._session if session is None: session = requests.Session() - cls._session = session + NBAHTTP._session = session return session @classmethod def set_session(cls, session) -> None: - cls._session = session + NBAHTTP._session = session def clean_contents(self, contents): return contents From e4a1719fc7fc6aa29d64a82727b83ba659b55ee1 Mon Sep 17 00:00:00 2001 From: Ashish Mistry Date: Tue, 19 May 2026 16:54:14 -0400 Subject: [PATCH 2/2] test: mock network requests in live boxscore and odds url tests --- tests/unit/live/endpoints/test_live_boxscore.py | 2 +- tests/unit/live/endpoints/test_live_odds.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/live/endpoints/test_live_boxscore.py b/tests/unit/live/endpoints/test_live_boxscore.py index 605a461d..03113356 100644 --- a/tests/unit/live/endpoints/test_live_boxscore.py +++ b/tests/unit/live/endpoints/test_live_boxscore.py @@ -486,7 +486,7 @@ def send_api_request( monkeypatch.setattr(NBAHTTP, "send_api_request", MockResponse.send_api_request) -def test_get_request_url(): +def test_get_request_url(nba_http_patch): assert ( boxscore.BoxScore(game_id).get_request_url() == "https://cdn.nba.com/static/json/liveData/boxscore/boxscore_0022000180.json" diff --git a/tests/unit/live/endpoints/test_live_odds.py b/tests/unit/live/endpoints/test_live_odds.py index fb8354ca..2f5bba36 100644 --- a/tests/unit/live/endpoints/test_live_odds.py +++ b/tests/unit/live/endpoints/test_live_odds.py @@ -416,7 +416,7 @@ def send_api_request( monkeypatch.setattr(NBAHTTP, "send_api_request", MockResponse.send_api_request) -def test_get_request_url(): +def test_get_request_url(nba_http_patch): assert ( odds.Odds().get_request_url() == "https://cdn.nba.com/static/json/liveData/odds/odds_todaysGames.json"