Skip to content

fix: add Guangzhou Loong Lions to static teams (#622) #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishmistry36 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add Guangzhou Loong Lions to static teams (#622) #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/nba_api/stats/library/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6272,6 +6272,16 @@
team_index_championship_year = 7

teams = [
[
15018,
"GUA",
"Loong Lions",
2000,
"Guangzhou",
"Guangzhou Loong Lions",
"Guangdong",
[],
],
[1610612737, "ATL", "Hawks", 1949, "Atlanta", "Atlanta Hawks", "Georgia", [1958]],
[
1610612738,
Expand Down
13 changes: 12 additions & 1 deletion tests/unit/stats/static/test_static_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,19 @@


def test_nba_teams():
assert len(teams.teams) == 30
assert len(teams.teams) == 31


def test_wnba_teams():
assert len(teams.wnba_teams) == 13


def test_find_team_by_abbreviation():
gua = teams.find_team_by_abbreviation("GUA")
assert gua is not None
assert gua["id"] == 15018
assert gua["full_name"] == "Guangzhou Loong Lions"
assert gua["nickname"] == "Loong Lions"
assert gua["city"] == "Guangzhou"
assert gua["state"] == "Guangdong"
assert gua["year_founded"] == 2000