feat: migrate to java 17

changes:
- update maven-compiler-plugin to latest 3.14.1
- update maven-javadoc-plugin to latest 3.12.0
- update jacoco-maven-plugin to latest 0.8.14
- set maven.compiler.release to 17
- set source to 17 and update link to javadoc for maven-javadoc-plugin configuration
- set java-version to 17 in github workflows
- set java version to 17 in swagger-gradle-plugin
- replace String.format with "str".formatted
- replace casts with pattern variables
- add @serial to serialVersionUID fields
- replace regular string literals with text blocks in tests
- replace Paths.get with Path.of
- replace new Integer with Integer.valueOf

Author: vpelikh

.github/workflows/codeql-analysis.yml

@@ -37,7 +37,7 @@ jobs:
     - name: Set up Java
       uses: actions/setup-java@v1
       with:
-        java-version: 11
+        java-version: 17
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3

.github/workflows/maven-pulls.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java: [ 11, 17 ]
+        java: [ 17, 25 ]
 
     steps:
     - uses: actions/checkout@v4

.github/workflows/maven.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java: [ 11, 17 ]
+        java: [ 17, 25 ]
 
     steps:
     - uses: actions/checkout@v4
@@ -41,7 +41,7 @@ jobs:
           cd ../..
           export MY_JAVA_VERSION=`java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1`
           echo "JAVA VERSION" ${MY_JAVA_VERSION}
-          if [[ ${MY_JAVA_VERSION} == "11" ]];
+          if [[ ${MY_JAVA_VERSION} == "17" ]];
           then
             export MY_POM_VERSION=`./mvnw -q -Dexec.executable="echo" -Dexec.args='${projects.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.3.1:exec`
             echo "POM VERSION" ${MY_POM_VERSION}

.github/workflows/prepare-release.yml

@@ -20,10 +20,10 @@ jobs:
       uses: actions/setup-python@v4
       with:
         python-version: '3.10'
-    - name: Set up Java 11
+    - name: Set up Java 17
       uses: actions/setup-java@v4
       with:
-        java-version: 11
+        java-version: 17
         distribution: temurin
         server-id: central
         server-username: MAVEN_USERNAME

.github/workflows/release.yml

@@ -20,10 +20,10 @@ jobs:
       uses: actions/setup-python@v4
       with:
         python-version: '3.10'
-    - name: Set up Java 11
+    - name: Set up Java 17
       uses: actions/setup-java@v4
       with:
-        java-version: 11
+        java-version: 17
         distribution: temurin
         server-id: central
         server-username: MAVEN_USERNAME

README.md

@@ -129,7 +129,7 @@ If you're interested in the change history of swagger and the Swagger Core frame
 ### Prerequisites
 You need the following installed and available in your $PATH:
 
-* Java 11
+* Java 17
 * Apache maven 3.0.4 or greater
 * Jackson 2.4.5 or greater
 

modules/swagger-core/pom.xml

@@ -55,7 +55,6 @@
         <dependency>
             <groupId>jakarta.xml.bind</groupId>
             <artifactId>jakarta.xml.bind-api</artifactId>
-            <version>2.3.3</version>
         </dependency>
         <dependency>
             <groupId>org.apache.commons</groupId>
@@ -121,6 +120,12 @@
             <artifactId>logback-core</artifactId>
             <scope>provided</scope>
         </dependency>
+        <dependency>
+            <groupId>jakarta.annotation</groupId>
+            <artifactId>jakarta.annotation-api</artifactId>
+            <version>1.3.5</version>
+            <scope>provided</scope>
+        </dependency>
         <dependency>
             <groupId>jakarta.validation</groupId>
             <artifactId>jakarta.validation-api</artifactId>

modules/swagger-core/src/main/java/io/swagger/v3/core/converter/ModelConverterContextImpl.java

@@ -55,7 +55,7 @@ public void defineModel(String name, Schema model, Type type, String prevName) {
     @Override
     public void defineModel(String name, Schema model, AnnotatedType type, String prevName) {
         if (LOGGER.isTraceEnabled()) {
-            LOGGER.trace(String.format("defineModel %s %s", name, model));
+            LOGGER.trace("defineModel %s %s".formatted(name, model));
         }
         modelByName.put(name, model);
 
@@ -87,7 +87,7 @@ public Schema resolve(AnnotatedType type) {
             processedTypes.add(type);
         }
         if (LOGGER.isDebugEnabled()) {
-            LOGGER.debug(String.format("resolve %s", type.getType()));
+            LOGGER.debug("resolve %s".formatted(type.getType()));
         }
         Iterator<ModelConverter> converters = this.getConverters();
         Schema resolved = null;

modules/swagger-core/src/main/java/io/swagger/v3/core/filter/SpecFilter.java

@@ -330,9 +330,9 @@ private void addSchemaRef(Schema schema, Set<String> referencedDefinitions) {
             }
         }
 
-        if (schema instanceof ArraySchema &&
-                ((ArraySchema) schema).getItems() != null) {
-            addSchemaRef(((ArraySchema) schema).getItems(), referencedDefinitions);
+        if (schema instanceof ArraySchema arraySchema &&
+                arraySchema.getItems() != null) {
+            addSchemaRef(arraySchema.getItems(), referencedDefinitions);
         } else if (schema.getTypes() != null && schema.getTypes().contains("array") && schema.getItems() != null) {
             addSchemaRef(schema.getItems(), referencedDefinitions);
         } else {

modules/swagger-core/src/main/java/io/swagger/v3/core/jackson/ExampleSerializer.java

@@ -19,8 +19,8 @@ public ExampleSerializer(JsonSerializer<Object> serializer) {
 
     @Override
     public void resolve(SerializerProvider serializerProvider) throws JsonMappingException {
-        if (defaultSerializer instanceof ResolvableSerializer) {
-            ((ResolvableSerializer) defaultSerializer).resolve(serializerProvider);
+        if (defaultSerializer instanceof ResolvableSerializer serializer) {
+            serializer.resolve(serializerProvider);
         }
     }