Skip to content

Commit ad9f60d

Browse files
authored
Merge pull request #43 from sw360/gernot/minor-fixes
update sw360python & refactor SBomWriter
2 parents 78365a6 + 4e503cb commit ad9f60d

2 files changed

Lines changed: 256 additions & 262 deletions

File tree

capycli/common/capycli_bom_support.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,9 @@
99
import json
1010
import os
1111
import pathlib
12-
import tempfile
1312
import uuid
1413
from datetime import datetime
1514
from enum import Enum
16-
from pathlib import Path
1715
from typing import Any, Dict, Iterable, List, Optional
1816

1917
from cyclonedx.model import (
@@ -618,14 +616,8 @@ def write_to_json(cls, sbom: Bom, outputfile: str, pretty_print: bool = False) -
618616
cls.remove_empty_properties_in_sbom(sbom)
619617

620618
if pretty_print:
621-
f = tempfile.NamedTemporaryFile(delete=False)
622-
output_file = Path(f.name)
623-
output_file.parent.mkdir(exist_ok=True, parents=True)
624-
writer.output_to_file(filename=f.name, allow_overwrite=True)
625-
jsondata = json_support.load_json_file(f.name)
626-
json_support.write_json_to_file(jsondata, outputfile)
627-
f.close()
628-
os.remove(f.name)
619+
jsondata = writer.output_as_string().encode('utf-8')
620+
json_support.write_json_to_file(json.loads(jsondata), outputfile)
629621
else:
630622
writer.output_to_file(filename=outputfile, allow_overwrite=True)
631623

0 commit comments

Comments
 (0)