Skip to content

Commit 9500c49

Browse files
committed
fix: Changes suggested in PR feedback
1 parent 86b9d70 commit 9500c49

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.circleci/setupAndTestWithFrontendWithDjango.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ uvicorn mysite.asgi:application --port 8080 &
5454
pid=$!
5555
uvicorn mysite.asgi:application --port 8082 &
5656
pid2=$!
57-
echo "django2x pid: " $pid ", pid2: " $pid2
5857
cd ../../../../supertokens-website/test/server
5958
npm i -d
6059
npm i git+https://github.com:supertokens/supertokens-node.git#$3

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"django": (
3232
[
3333
"django-cors-headers==3.11.0",
34-
"django==3.2.12",
34+
"django==3",
3535
"django-stubs==1.9.0",
3636
"uvicorn==0.18.2",
3737
"python-dotenv==0.19.2",
@@ -40,7 +40,7 @@
4040
"django2x": (
4141
[
4242
"django-cors-headers==2.0",
43-
"django==2.2",
43+
"django==2",
4444
"django-stubs==1.9.0",
4545
"python-dotenv==0.19.2",
4646
]

tests/supertokens_python/test_supertokens_functions.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
from typing import List
1616

17-
from pytest import mark, skip
17+
from pytest import mark
1818
from tests.utils import clean_st, reset, setup_st, start_st
1919

2020
from supertokens_python import InputAppInfo, SupertokensConfig
@@ -75,8 +75,8 @@ async def test_supertokens_functions():
7575

7676
version = await Querier.get_instance().get_api_version()
7777
if not is_version_gte(version, "2.10"):
78-
# If the version less than 2.10, delete user feature didn't exist, so skip the test
79-
skip()
78+
# If the version is less than 2.10, delete user feature doesn't exist, so mark the test successful
79+
return
8080

8181
# Delete the 2nd user (bar@example.com)
8282
await st_asyncio.delete_user(user_ids[1])

0 commit comments

Comments
 (0)