Skip to content

feat(storage): add pyiceberg wrapper #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o-santi wants to merge 3 commits into
base: main
Choose a base branch
from
+446 −6
Open

feat(storage): add pyiceberg wrapper #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9daf5c
feat(storage): add pyiceberg wrapper
o-santi Dec 4, 2025
8d5cf45
fix(store): properly pass in access keys and tokens
o-santi Dec 5, 2025
defd3d4
chore(storage): remove hard coded region, remove comment
o-santi Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/storage/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ dependencies = [
"deprecation >=2.1.0",
"pydantic >=2.11.7",
"yarl>=1.20.1",
"pyiceberg>=0.10.0",
]

[project.urls]
Expand Down
22 changes: 22 additions & 0 deletions src/storage/src/storage3/_async/analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import List, Optional

from httpx import QueryParams
from pyiceberg.catalog.rest import RestCatalog

from ..types import (
AnalyticsBucket,
Expand Down Expand Up @@ -49,3 +50,24 @@ async def delete(self, bucket_name: str) -> AnalyticsBucketDeleteResponse:
http_method="DELETE", path=["bucket", bucket_name]
)
return AnalyticsBucketDeleteResponse.model_validate_json(data.content)

def catalog(
self, catalog_name: str, access_key_id: str, secret_access_key: str
) -> RestCatalog:
catalog_uri = self._request._base_url
s3_endpoint = self._request._base_url.parent.joinpath("s3")
service_key = self._request.headers.get("apiKey")
assert service_key, "apiKey must be passed in the headers."
return RestCatalog(
catalog_name,
warehouse=catalog_name,
uri=str(catalog_uri),
token=service_key,
**{
"py-io-impl": "pyiceberg.io.pyarrow.PyArrowFileIO",
"s3.endpoint": str(s3_endpoint),
"s3.access-key-id": access_key_id,
"s3.secret-access-key": secret_access_key,
"s3.force-virtual-addressing": "False",
},
)
22 changes: 22 additions & 0 deletions src/storage/src/storage3/_sync/analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import List, Optional

from httpx import QueryParams
from pyiceberg.catalog.rest import RestCatalog

from ..types import (
AnalyticsBucket,
Expand Down Expand Up @@ -47,3 +48,24 @@ def list(
def delete(self, bucket_name: str) -> AnalyticsBucketDeleteResponse:
data = self._request.send(http_method="DELETE", path=["bucket", bucket_name])
return AnalyticsBucketDeleteResponse.model_validate_json(data.content)

def catalog(
self, catalog_name: str, access_key_id: str, secret_access_key: str
) -> RestCatalog:
catalog_uri = self._request._base_url
s3_endpoint = self._request._base_url.parent.joinpath("s3")
service_key = self._request.headers.get("apiKey")
assert service_key, "apiKey must be passed in the headers."
return RestCatalog(
catalog_name,
warehouse=catalog_name,
uri=str(catalog_uri),
token=service_key,
**{
"py-io-impl": "pyiceberg.io.pyarrow.PyArrowFileIO",
"s3.endpoint": str(s3_endpoint),
"s3.access-key-id": access_key_id,
"s3.secret-access-key": secret_access_key,
"s3.force-virtual-addressing": "False",
},
)
Loading