-
-
Notifications
You must be signed in to change notification settings - Fork 219
feat: add stage 1 AMI build caching based on input hash #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jfroche
wants to merge
11
commits into
develop
Choose a base branch
from
ci/cache-stage1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+436
−219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a14659 to
fae40c8
Compare
23cd71a to
793d9d9
Compare
c870e16 to
9524496
Compare
Implement content-based caching for stage 1 AMI builds by computing a hash from all input sources. Then the build-ami script checks for existing AMIs with matching input hash before building.
… add actionlint Consolidate duplicate AMI build steps across workflows into a shared composite action. Also introduces actionlint configuration for GitHub Actions validation for the modified workflows.
220ccf9 to
6a25455
Compare
0c2e1d9 to
0b25bbd
Compare
In order to differentiate AMIs built for testing and those built for release, we need different AMI name. This commit introduces a new input parameter `ami_name_prefix`. For test builds, we set this prefix to include the GitHub run ID, ensuring uniqueness across test builds. For release builds, we use a static prefix "supabase-postgres".
The force-deregister variable is not used in the stage2-nix-psql.pkr.hcl
0b25bbd to
91bdf48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement content-based caching for stage 1 AMI builds by computing a hash from all input sources. Then the build-ami script checks for existing AMIs with matching input hash before building.