Problems with partials after updating from 4.3.3 to 6.3.2

[Weasy666]

I've taken over a project in our company, which wasn't maintained in quite a while, so i have updated the used handlebars version from 4.3.3 to 6.3.2.
It was pretty painless code wise,, so thanks for that. 🙂

But partials are kinda broken for us right now.

A template looking similar to this

{{#if some_condition }}
    {{> some_partial }}
{{/if}}

works fine in version 4.3.3, but breaks in 6.3.2 with a Partial not found @partial-block error.

But if we change it to a partial block, then it works fine.

{{#if some_condition }}
    {{#> some_partial }}
    {{/some_partial }}
{{/if}}

Nothing was changed in our code in regard to registering partials. I'm pretty new to handlebars and am not sure what's going on here.
Is this a bug?

[sunng87]

hello @Weasy666 , this is a known issue with nested @partial-block. The implementation of nested @partial-block has been incorrect in our 6.x and in 6.3.2 I tried to fix it but still haven't finished it.

I'm aware of this but I'm just too busy to look into it these days.

[Weasy666]

Ah... ok. Thanks for the quick answer. 🙂
I don't know if it's helpful, i also tried with version 5 and that too is broken for us.

Do you have a hunch on what is broken and would be something a first time contributor possibly fix?

[sunng87]

Sorry for being late. I finally got some break to look into this. For more information, could you give me an example of how your some_partial looks like?

When using @partial-block, it points to the content between {{#> some_partial }}{{/some_partial }}, so if you get @partial-block not found for {{> some_partial}}, it might be a correct behaviour.

[BenjaminBrandtnerWF]

Hello, I can provide the example.

Our some_partial looks like this:

some_partial.hbs:

unrelated_content
{{> @partial-block }}
unrelated_content

We have two use cases, two independent files calling that partial:

example1.hbs: (working)

unrelated_content
    {{#if some_condition}}
        {{#> some_partial }}
        some_content
        {{/ some_partial }}
    {{/if}}
unrelated_content

example2.hbs: (not working)

unrelated_content
    {{#if some_condition}}
        {{> some_partial}}
    {{/if}}
unrelated_content

(I assume the conditions are not important, but for completeness sake I added them.)

As you can see from one file we want to pass content to the partial from the other we don't want to do that. But example2.hbs throws the error.