run clean on all the containers on the shared root

`ybox-pkg clean` may have container specific cache to be cleared (e.g. AUR cache for
    Arch Linux), so run it on all active containers on the selected shared root

Author: sumwale

src/ybox/conf/resources/entrypoint-user.sh

@@ -10,7 +10,7 @@ current_user="$(id -un)"
 user_home="$(getent passwd "$current_user" | cut -d: -f6)"
 # set gpg keyserver to an available one
 mkdir -p "$user_home/.gnupg" && chmod 0700 "$user_home/.gnupg"
-echo "keyserver $DEFAULT_GPG_KEY_SERVER" > "$user_home/.gnupg/dirmngr.conf"
+echo "keyserver $DEFAULT_GPG_KEY_SERVER" > "$user_home/.gnupg/dirmngr.conf" || /bin/true
 rm -f "$user_home"/.gnupg/*/*.lock
 
 if [ ! -e "$user_home/.config/pip/pip.conf" ]; then

src/ybox/pkg/clean.py

@@ -5,23 +5,39 @@
 import argparse
 from configparser import SectionProxy
 
-from ybox.cmd import PkgMgr, build_shell_command, run_command
+from ybox.cmd import (PkgMgr, build_shell_command, check_active_ybox,
+                      run_command)
 from ybox.config import StaticConfiguration
 from ybox.print import print_info
+from ybox.state import RuntimeConfiguration, YboxStateManagement
 
 
+# noinspection PyUnusedLocal
 def clean_cache(args: argparse.Namespace, pkgmgr: SectionProxy, docker_cmd: str,
-                conf: StaticConfiguration) -> int:
+                conf: StaticConfiguration, runtime_conf: RuntimeConfiguration,
+                state: YboxStateManagement) -> int:
+    # pylint: disable=unused-argument
     """
     Clean package cache and related intermediate files.
 
-    :param args: arguments having `quiet` and all other attributes passed by the user
+    :param args: arguments having `package` and all other attributes passed by the user
     :param pkgmgr: the `[pkgmgr]` section from `distro.ini` configuration file of the distribution
     :param docker_cmd: the podman/docker executable to use
     :param conf: the :class:`StaticConfiguration` for the container
+    :param runtime_conf: the `RuntimeConfiguration` of the container
+    :param state: instance of `YboxStateManagement` having the state of all ybox containers
     :return: integer exit status of clean command where 0 represents success
     """
-    print_info(f"Cleaning package cache in container '{conf.box_name}'")
-    clean_cmd = pkgmgr[PkgMgr.CLEAN_QUIET.value] if args.quiet else pkgmgr[PkgMgr.CLEAN.value]
-    return int(run_command(build_shell_command(docker_cmd, conf.box_name, clean_cmd),
-                           exit_on_error=False, error_msg="cleaning package cache"))
+    clean_cmd = pkgmgr[PkgMgr.CLEAN.value] if args.ask else pkgmgr[PkgMgr.CLEAN_QUIET.value]
+    # run clean for each container since it can involve actions that are container specific
+    # apart from the generic ones for the shared root (e.g. AUR cache cleaning for Arch Linux)
+    code = 0
+    for container in state.get_containers(shared_root=runtime_conf.shared_root):
+        if not check_active_ybox(docker_cmd, container):
+            continue
+        print_info(f"Cleaning package cache in container '{container}'")
+        if (c := int(run_command(build_shell_command(docker_cmd, container, clean_cmd),
+                                 exit_on_error=False, error_msg="cleaning package cache"))) != 0:
+            code = c
+        print()
+    return code

src/ybox/run/pkg.py

@@ -376,7 +376,8 @@ def add_clean(subparser: argparse.ArgumentParser) -> None:
 
     :param subparser: the :class:`argparse.ArgumentParser` object for the sub-command
     """
-    subparser.set_defaults(needs_state=False)
+    subparser.add_argument("-A", "--ask", action="store_true",
+                           help="ask before each action else silently clean everything")
     subparser.set_defaults(group_by_shared_root=True)
     subparser.set_defaults(func=clean_cache)