refactor(lsp): clean up completion handler and add unit tests

Author: sudo-tee

lua/opencode/lsp/opencode_completion_ls.lua

@@ -43,7 +43,6 @@ local function get_completion_context(params)
   local line = lines[1] or ''
   local line_to_cursor = line:sub(1, col)
 
-  -- Find the trigger character
   local triggers = completion.get_trigger_characters()
   for _, t in ipairs(triggers) do
     if t and line_to_cursor:match(vim.pesc(t) .. '[^%s]*$') then
@@ -100,7 +99,7 @@ end
 
 ---Completion handler - provides completion items
 ---@param params lsp.CompletionParams
----@param callback fun(err?: lsp.ResponseError, result: lsp.CompletionItem[])
+---@param callback fun(err?: lsp.ResponseError, result: lsp.CompletionItem[] | lsp.CompletionList)
 handlers[ms.textDocument_completion] = function(params, callback)
   local word, trigger_char, line = get_completion_context(params)
 
@@ -124,8 +123,8 @@ handlers[ms.textDocument_completion] = function(params, callback)
   Promise.all(promises)
     :and_then(function(results)
       local all_items = {}
-
       local is_incomplete = false
+
       for i, items in ipairs(results) do
         for _, item in ipairs(items or {}) do
           local source = completion.get_source_by_name(item.source_name)
@@ -137,10 +136,7 @@ handlers[ms.textDocument_completion] = function(params, callback)
         end
       end
 
-      callback(nil, {
-        isIncomplete = is_incomplete,
-        items = all_items,
-      })
+      callback(nil, { isIncomplete = is_incomplete, items = all_items })
       completion.store_completion_items(all_items)
     end)
     :catch(function(err)
@@ -150,15 +146,6 @@ handlers[ms.textDocument_completion] = function(params, callback)
     end)
 end
 
----Resolve handler - provides additional documentation for completion items
----@param params lsp.CompletionItem
----@param callback fun(err?: lsp.ResponseError, result: lsp.CompletionItem)
-handlers[ms.completionItem_resolve] = function(params, callback)
-  local item = vim.deepcopy(params)
-
-  callback(nil, item)
-end
-
 ---Create the LSP server configuration
 ---@return vim.lsp.ClientConfig
 function M.create_config()

tests/unit/api_spec.lua

@@ -146,40 +146,6 @@ describe('opencode.api', function()
     end)
   end)
 
-  describe('completion triggers', function()
-    it('does not restore cursor position for context_items', function()
-      local config = require('opencode.config')
-      local original_get_key_for_function = config.get_key_for_function
-      local original_completion = package.loaded['opencode.ui.completion']
-
-      config.get_key_for_function = function(scope, function_name)
-        if scope == 'input_window' and function_name == 'context_items' then
-          return '#'
-        end
-        return original_get_key_for_function(scope, function_name)
-      end
-
-      local trigger_char = nil
-      package.loaded['opencode.ui.completion'] = {
-        trigger_completion = function(char)
-          return function()
-            trigger_char = char
-          end
-        end,
-      }
-
-      stub(ui, 'focus_input')
-
-      api.context_items()
-
-      config.get_key_for_function = original_get_key_for_function
-      package.loaded['opencode.ui.completion'] = original_completion
-
-      assert.stub(ui.focus_input).was_called_with({ restore_position = false, start_insert = true })
-      assert.equal('#', trigger_char)
-    end)
-  end)
-
   describe('run command argument parsing', function()
     it('parses agent prefix and passes to send_message', function()
       api.commands.run.fn({ 'agent=plan', 'analyze', 'this', 'code' }):wait()