fix(config_file): respect hidden agents and avoid duplicates (#263)

Author: hermandavid

lua/opencode/config_file.lua

@@ -92,7 +92,7 @@ M.get_opencode_agents = Promise.async(function()
   local agents = {}
   for agent, opts in pairs(cfg.agent or {}) do
     -- Only include agents that are enabled and have the right mode
-    if opts.disable ~= true and (opts.mode == 'primary' or opts.mode == 'all') then
+    if opts.disable ~= true and opts.hidden ~= true and (opts.mode == 'primary' or opts.mode == 'all') then
       table.insert(agents, agent)
     end
   end
@@ -102,7 +102,7 @@ M.get_opencode_agents = Promise.async(function()
   for _, mode in ipairs({ 'plan', 'build' }) do
     if not vim.tbl_contains(agents, mode) then
       local mode_config = cfg.agent and cfg.agent[mode]
-      if mode_config == nil or (mode_config.disable ~= true) then
+      if mode_config == nil or (mode_config.disable ~= true and mode_config.hidden ~= true) then
         table.insert(agents, 1, mode)
       end
     end
@@ -119,11 +119,20 @@ M.get_subagents = Promise.async(function()
 
   local subagents = {}
   for agent, opts in pairs(cfg.agent or {}) do
-    if opts.mode ~= 'primary' or opts.mode == 'all' then
+    -- Only include agents that are not disabled, not hidden, and not primary-only
+    if opts.disable ~= true and opts.hidden ~= true and (opts.mode ~= 'primary' or opts.mode == 'all') then
       table.insert(subagents, agent)
     end
   end
-  table.insert(subagents, 1, 'general')
+
+  for _, default_agent in ipairs({ 'general', 'explore' }) do
+    if not vim.tbl_contains(subagents, default_agent) then
+      local agent_config = cfg.agent and cfg.agent[default_agent]
+      if agent_config == nil or (agent_config.disable ~= true and agent_config.hidden ~= true) then
+        table.insert(subagents, 1, default_agent)
+      end
+    end
+  end
 
   return subagents
 end)

tests/unit/config_file_spec.lua

@@ -85,6 +85,110 @@ describe('config_file.setup', function()
     end):wait()
   end)
 
+  it('get_opencode_agents filters out hidden agents', function()
+    Promise.spawn(function()
+      state.api_client = {
+        get_config = function()
+          return Promise.new():resolve({
+            agent = {
+              ['custom'] = { mode = 'primary' },
+              ['compaction'] = { mode = 'primary', hidden = true },
+              ['title'] = { mode = 'primary', hidden = true },
+            },
+          })
+        end,
+        get_current_project = function()
+          return Promise.new():resolve({ id = 'p1' })
+        end,
+      }
+      local agents = config_file.get_opencode_agents():await()
+      assert.True(vim.tbl_contains(agents, 'custom'))
+      assert.False(vim.tbl_contains(agents, 'compaction'))
+      assert.False(vim.tbl_contains(agents, 'title'))
+    end):wait()
+  end)
+
+  it('get_subagents filters out hidden agents', function()
+    Promise.spawn(function()
+      state.api_client = {
+        get_config = function()
+          return Promise.new():resolve({
+            agent = {
+              ['explore'] = { mode = 'all' },
+              ['compaction'] = { mode = 'all', hidden = true },
+              ['summary'] = { hidden = true },
+            },
+          })
+        end,
+        get_current_project = function()
+          return Promise.new():resolve({ id = 'p1' })
+        end,
+      }
+      local agents = config_file.get_subagents():await()
+      assert.True(vim.tbl_contains(agents, 'general'))
+      assert.True(vim.tbl_contains(agents, 'explore'))
+      assert.False(vim.tbl_contains(agents, 'compaction'))
+      assert.False(vim.tbl_contains(agents, 'summary'))
+    end):wait()
+  end)
+
+  it('get_subagents does not duplicate built-in agents when configured', function()
+    Promise.spawn(function()
+      state.api_client = {
+        get_config = function()
+          return Promise.new():resolve({
+            agent = {
+              ['general'] = { mode = 'subagent', model = 'custom/model' },
+              ['explore'] = { mode = 'all', temperature = 0.5 },
+              ['custom'] = { mode = 'subagent' },
+            },
+          })
+        end,
+        get_current_project = function()
+          return Promise.new():resolve({ id = 'p1' })
+        end,
+      }
+      local agents = config_file.get_subagents():await()
+
+      -- Count occurrences of each agent
+      local general_count = 0
+      local explore_count = 0
+      for _, agent in ipairs(agents) do
+        if agent == 'general' then
+          general_count = general_count + 1
+        elseif agent == 'explore' then
+          explore_count = explore_count + 1
+        end
+      end
+
+      -- Each should appear exactly once
+      assert.equal(1, general_count, 'general should appear exactly once')
+      assert.equal(1, explore_count, 'explore should appear exactly once')
+      assert.True(vim.tbl_contains(agents, 'custom'))
+    end):wait()
+  end)
+
+  it('get_subagents respects disabled built-in agents', function()
+    Promise.spawn(function()
+      state.api_client = {
+        get_config = function()
+          return Promise.new():resolve({
+            agent = {
+              ['general'] = { disable = true },
+              ['explore'] = { hidden = true },
+            },
+          })
+        end,
+        get_current_project = function()
+          return Promise.new():resolve({ id = 'p1' })
+        end,
+      }
+      local agents = config_file.get_subagents():await()
+      assert.False(vim.tbl_contains(agents, 'general'))
+      assert.False(vim.tbl_contains(agents, 'explore'))
+    end):wait()
+  end)
+
   it('get_opencode_project returns project', function()
     Promise.spawn(function()
       local project = { id = 'p1', name = 'X' }