fix(input_window): disable dynamic height if min_height == max_height (#260)

* fix(input_window): disable dynamic height if min_height == max_height

* test: add unit test to check that dynamic resize can be disabled

* refactor: fix type warning

* test: add unit test for dynamic height enabled

Author: disrupted

lua/opencode/ui/input_window.lua

@@ -38,8 +38,14 @@ local function get_winbar_height(windows)
   return 0
 end
 
+local dynamic_height_enabled = config.ui.input.min_height ~= config.ui.input.max_height
+
+---@return integer
 local function calculate_height(windows)
   local total_height = vim.api.nvim_get_option_value('lines', {})
+  if not dynamic_height_enabled then
+    return math.floor(total_height * config.ui.input.min_height)
+  end
   local min_height = math.max(1, math.floor(total_height * config.ui.input.min_height))
   local max_height = math.max(min_height, math.floor(total_height * config.ui.input.max_height))
   local content_height = get_content_height(windows) + get_winbar_height(windows)
@@ -274,7 +280,6 @@ function M.setup(windows)
   if config.ui.position ~= 'current' then
     set_win_option('winfixbuf', true, windows)
   end
-  set_win_option('winfixheight', true, windows)
   set_win_option('winfixwidth', true, windows)
 
   M.update_dimensions(windows)
@@ -295,18 +300,21 @@ function M.update_dimensions(windows)
 end
 
 function M.schedule_resize(windows)
+  if not dynamic_height_enabled then
+    return
+  end
   windows = windows or state.windows
   if not M.mounted(windows) or M._resize_scheduled then
     return
   end
 
   M._resize_scheduled = true
-  vim.schedule(function()
+  vim.defer_fn(function()
     M._resize_scheduled = false
     if M.mounted(windows) then
       M.update_dimensions(windows)
     end
-  end)
+  end, math.floor(1000 / 60)) -- throttle to 60 FPS
 end
 
 function M.refresh_placeholder(windows, input_lines)

tests/unit/zoom_spec.lua

@@ -126,6 +126,79 @@ describe('ui zoom state', function()
 
       assert.equals(80, state.pre_zoom_width)
     end)
+
+    it('calls update_dimensions when dynamic height is enabled', function()
+      config.setup({
+        ui = {
+          input = {
+            min_height = 0.1,
+            max_height = 0.25,
+          },
+        },
+      })
+
+      package.loaded['opencode.ui.input_window'] = nil
+      local dynamic_height_input_window = require('opencode.ui.input_window')
+
+      local update_calls = 0
+      local original_defer_fn = vim.defer_fn
+      local original_update_dimensions = dynamic_height_input_window.update_dimensions
+
+      vim.defer_fn = function(fn)
+        fn()
+      end
+
+      dynamic_height_input_window.update_dimensions = function(...)
+        update_calls = update_calls + 1
+        return original_update_dimensions(...)
+      end
+
+      dynamic_height_input_window.schedule_resize(windows)
+
+      assert.equals(1, update_calls)
+
+      vim.defer_fn = original_defer_fn
+      dynamic_height_input_window.update_dimensions = original_update_dimensions
+      package.loaded['opencode.ui.input_window'] = nil
+      require('opencode.ui.input_window')
+    end)
+
+    it('does not call update_dimensions when dynamic height disabled (fixed input height)', function()
+      config.setup({
+        ui = {
+          input = {
+            min_height = 0.2,
+            max_height = 0.2,
+          },
+        },
+      })
+
+      package.loaded['opencode.ui.input_window'] = nil
+      local fixed_height_input_window = require('opencode.ui.input_window')
+
+      local update_calls = 0
+      local original_update_dimensions = fixed_height_input_window.update_dimensions
+      fixed_height_input_window.update_dimensions = function(...)
+        update_calls = update_calls + 1
+        return original_update_dimensions(...)
+      end
+
+      fixed_height_input_window.schedule_resize(windows)
+
+      assert.equals(0, update_calls)
+
+      fixed_height_input_window.update_dimensions = original_update_dimensions
+      config.setup({
+        ui = {
+          input = {
+            min_height = 0.1,
+            max_height = 0.25,
+          },
+        },
+      })
+      package.loaded['opencode.ui.input_window'] = nil
+      require('opencode.ui.input_window')
+    end)
   end)
 
   describe('output_window.update_dimensions', function()