fix(client): handle merged payment challenges#7
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WWW-Authenticateheaders withChallenge.from_www_authenticate_listin the client transport.Why
Paymentchallenges, but the client transport only tried to parse each header value as one challenge.WWW-Authenticatevalues into one header, so the client should still find a supported MPP method.Verification
mise exec ruby@3.3.11 -- ruby -Ilib -Itest test/mpp/test_client.rbmise exec ruby@3.3.11 -- ruby -Ilib -Itest test/mpp/test_parsing.rbmise exec ruby@3.3.11 -- ruby -c lib/mpp/client/transport.rbmise exec ruby@3.3.11 -- ruby -c test/mpp/test_client.rbgit diff --checkNotes
mise exec ruby@3.3.11 -- bundle exec rake test test/mpp/test_client.rb; local dependency installation is blocked by nativerbsecp256k1build prerequisites (aclocal/automake) on this machine, so I ran the focused tests directly with the repolibandtestload paths.