fix(stripe): pass idempotency key for charge intents#6
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Stripe idempotency key when the Ruby Stripe charge intent creates and confirms a PaymentIntent.
The key is derived from the MPP challenge ID, so retries of the same verified charge operation reuse the same logical Stripe request instead of risking a duplicate PaymentIntent creation. This matches Stripe's guidance to pass idempotency keys in request options for POST create/update calls.
Changes
{ idempotency_key: ... }as the Stripe SDK request options when creating the PaymentIntentmpp-stripe-charge-<challenge_id>Verification
mise exec ruby@3.3 -- ruby -Ilib:test test/mpp/methods/stripe/test_charge_intent.rbmise exec ruby@3.3 -- standardrb lib/mpp/methods/stripe/charge_intent.rb test/mpp/methods/stripe/test_charge_intent.rbgit diff --checkNote: full
bundle installcould not complete in my local macOS environment because therbsecp256k1native extension needsaclocalwhile buildingeth. The targeted Stripe test and StandardRB check both ran successfully after installing Ruby 3.3 with mise.