webdriver_options: add explicit binary path on Windows, set --headless=new

Author: stanislaw

html2print/html2print.py

@@ -311,30 +311,44 @@ def create_webdriver(
 ) -> webdriver.Chrome:
     print("html2print: creating ChromeDriver service.", flush=True)  # noqa: T201
 
-    path_to_chrome: str
+    path_to_chrome_driver: str
     if chromedriver_argument is None:
-        path_to_chrome = ChromeDriverManager().get_chrome_driver(
+        path_to_chrome_driver = ChromeDriverManager().get_chrome_driver(
             path_to_cache_dir
         )
     else:
-        path_to_chrome = chromedriver_argument
-    print(f"html2print: ChromeDriver available at path: {path_to_chrome}")  # noqa: T201
+        path_to_chrome_driver = chromedriver_argument
+    print(  # noqa: T201
+        f"html2print: ChromeDriver available at path: {path_to_chrome_driver}"
+    )
 
     if debug:
         service = Service(
-            path_to_chrome, log_output=PATH_TO_CHROME_DRIVER_DEBUG_LOG
+            path_to_chrome_driver, log_output=PATH_TO_CHROME_DRIVER_DEBUG_LOG
         )
     else:
-        service = Service(path_to_chrome)
+        service = Service(path_to_chrome_driver)
 
     webdriver_options = Options()
+
+    # Workaround for Windows: Chrome is not typically found in the PATH, so
+    # need to supply the exact binary location manually.
+    if platform.system() == "Windows":
+        webdriver_options.binary_location = path_to_chrome_driver
+
     webdriver_options.add_argument("start-maximized")
     webdriver_options.add_argument("disable-infobars")
     # Doesn't seem to be needed.
     # webdriver_options.add_argument('--disable-gpu')  # noqa: ERA001
     webdriver_options.add_argument("--disable-extensions")
     webdriver_options.add_argument("--headless=chrome")
     # FIXME: This is not nice but otherwise it does not work in Ubuntu 24-based Docker image.
+
+    # Docker disables some syscalls that are required for Chrome's sandbox to work.
+    # https://stackoverflow.com/questions/68855734/how-to-setup-chrome-sandbox-on-docker-container
+    # We prefer isolation of the container over isolation of tabs within Chrome,
+    # and thus disable the sandbox.
+    # See also:
     # https://github.com/SeleniumHQ/selenium/issues/15327#issuecomment-2689287561
     webdriver_options.add_argument("--no-sandbox")