Skip to content

Issues.md

Latest commit

 

History

History
222 lines (147 loc) · 4.59 KB

Issues.md

File metadata and controls

222 lines (147 loc) · 4.59 KB

Issues in Nova 2.1

This is a list of issues found while validating the extensions shipped with Nova 2.1.

CSS

Syntax identifiers

The <syntax> element has an <identifiers> child:

<identifiers>
    <characters>
        <alphanumeric />
        <string>-_</string>
    </characters>
    <prefixes>
        <string>#</string>
    </prefixes>
</identifiers>

This undocumented element appears in other extensions too.

Captures on <strings>

A <strings> element with a suffix= attribute can be followed by captures:

<starts-with>
    <strings suffix="(:)?">
        <string>any-hover</string>
        <string>any-pointer</string>
        ...
        <string>min-width</string>
        <string>max-width</string>
    </strings>
    <capture number="1" name="css.style.media-feature.keyword" />
    <capture number="2" name="css.style.media-feature.separator" />
</starts-with>

This makes sense, but it isn't clear from the documentation that this is possible.

prefixsuffix attribute

This looks like a typo:

<strings case-insensitive="true" prefixsuffix="(?=\()">

Expression capture attribute

A single case of <expression capture="1" in one of the CSS completion behaviors. What does it mean?

Description attribute on completions.

A completion string="..." description="..." appeared. Is this attribute used?

Assistant element

A completion provider contains an <assistant type="files" /> element.

HTML

Documentation lookup

A number of syntax scopes have a lookup="documentation", but the documentation only mentions the possibilities:

attribute lookup { "inherit"|"lookup"|"dictionary" }?,

Unclosed parent or extend-parent

The symbol context attribute unclosed has a documented value of extend-parent, byt the HTML syntax uses:

<context behavior="start" group-by-name="true" unclosed="parent">

So do some of the examples in the documentation.

Subsyntax collection attribute

Can a subsyntax reference a collection of another syntax?

<subsyntax name="css" collection="attributes">

This isn't documented.

Regex templates

What's this?

<ends-with>
    <template>\3</template>
    <capture number="0" name="html.tag.attribute.value.quote.right" />
</ends-with>

Named, reusable regex fragments like Lex offers would be cool.

Syntax reference on provider symbols

In an HTML completion provider:

<symbols type="style-class" syntax="css" />

Is this a leftover from an older schema?

Behavior variables

This variables attribute does not seem to be documented:

<behavior variables="true" suffix="(?!&gt;)">

Strings in completion set

Maybe from an older schema?

    <set name="html.entities">
        <string>&amp;quot;</string>
        <string>&amp;apos;</string>

Markdown

Multiple surrounding-pairs elements

The Markdown extension has two <surrounding-pairs> elements. Looks like a copy-pasto.

Dynamic subsyntax redirection

The code blocks handle dynamic subsyntaxes like this:

<subsyntax capture="2">
    <alias key="objc" value="objective-c" />

This mechanism is not documented (maybe intentionally?).

PHP

Static completion names

In Completions/PHP.xml there's a bunch of static completions with a name attribute:

<completion name="php.HttpDeflateStream::__construct" string="HttpDeflateStream::__construct">
    <behavior symbol="function">
        <append>($[int $flags = 0])</append>
    </behavior>
</completion>

Python

Symbols element in top-level syntax definition

Python's <syntax> element contains:

<symbols redefinition="within-construct">
    <local scope="within-construct" />

    <documentation mode="after" match="string" match-multiple="comment" />
    <documentation mode="before" match-multiple="comment" skip="decorator" />
</symbols>

Unknown value for export-local

The export-local context attribute is documented as a boolean, but Python uses:

<context behavior="whitespace" export-local="property" />

Ruby

Invalid syntax name

The + sign is not allowed in syntax names:

<syntax name="html+erb">

Sass

Override collections

This override feature is not documented:

<collection name="directives" override="true">

Typescript

Scope-level include scope

This looks like a bug:

<scope name="typescript.arguments">
    <include syntax="self" collection="comments" />
    <starts-with>
        <expression>\(</expression>
        <capture number="0" name="typescript.bracket" />
    </starts-with>