Sympy_writer error when inlining

[sergisiso]

When attempting to inline ice_perm_eff in NEMOv5 icethd_pnd.f90

    inline_trans.apply(call, options=options)
  File "/home/HCHPSE01/nxn02/sss33-nxn02/workspace/psyclone/PSyclone/src/psyclone/psyir/transformations/inline_trans.py", line 218, in apply
    self._optional_arg_eliminate_ifblock_if_const_condition(routine)
  File "/home/HCHPSE01/nxn02/sss33-nxn02/workspace/psyclone/PSyclone/src/psyclone/psyir/transformations/inline_trans.py", line 425, in _optional_arg_eliminate_ifblock_if_const_condition
    sym_maths.expand(condition)
  File "/home/HCHPSE01/nxn02/sss33-nxn02/workspace/psyclone/PSyclone/src/psyclone/core/symbolic_maths.py", line 411, in expand
    sympy_expression = sympy_writer(expr)
                       ^^^^^^^^^^^^^^^^^^
  File "/home/HCHPSE01/nxn02/sss33-nxn02/workspace/psyclone/PSyclone/src/psyclone/psyir/backend/sympy_writer.py", line 589, in __call__
    expression_str_list = self._to_str(
                          ^^^^^^^^^^^^^
  File "/home/HCHPSE01/nxn02/sss33-nxn02/workspace/psyclone/PSyclone/src/psyclone/psyir/backend/sympy_writer.py", line 523, in _to_str
    self._create_type_map(list_of_expressions,
  File "/home/HCHPSE01/nxn02/sss33-nxn02/workspace/psyclone/PSyclone/src/psyclone/psyir/backend/sympy_writer.py", line 394, in _create_type_map
    orig_sym = sva[0].node.scope.symbol_table.lookup(sig.var_name)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/HCHPSE01/nxn02/sss33-nxn02/workspace/psyclone/PSyclone/src/psyclone/psyir/symbols/symbol_table.py", line 1078, in lookup
    raise KeyError(f"Could not find '{name}' in the Symbol "
KeyError: "Could not find 'epsi06' in the Symbol Table."

'epsi06' is an unqualified import at the module level

[hiker]

Hmm, there is code in place that handles a SymbolError in sympy_writer around line 394:

           try:
                # Depending on the situation, we won't always
                # have a scope, hence the try...except.
                orig_sym = sva[0].node.scope.symbol_table.lookup(sig.var_name)
            except SymbolError:
                # If we can't find it, use the symbol associated to the sva
                orig_sym = None
                if isinstance(sva[0].node, Reference):
                    orig_sym = sva[0].node.symbol

I wonder if it's sufficient to just add KeyError to the exception handling?

[sergisiso]

Yes that worked